| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
HedgeDoc allows to specify custom Open Graph tags using the
`opengraph` key in the YAML metadata of a note.
These are rendered into the HTML delivered to clients using `ejs` and
its `<%-` tag. This outputs the variable unescaped into the template
and therefore allows to inject arbitrary strings,
including `<script>` tags.
This commit changes the template to use ejs's `<%=` tag instead,
which automatically escapes the variables content,
thereby mitigating the XSS vector.
See also https://github.com/hedgedoc/hedgedoc/security/advisories/GHSA-gjg7-4j2h-94fq
Co-authored-by: Christoph (Sheogorath) Kern <sheogorath@shivering-isles.com>
Signed-off-by: David Mehren <git@herrmehren.de>
|
|
|
|
| |
Signed-off-by: David Mehren <git@herrmehren.de>
|
|
|
|
| |
Signed-off-by: David Mehren <git@herrmehren.de>
|
|
|
|
|
|
|
| |
CVE-2021-29475 has been fixed since
HedgeDoc 1.5.0, instead of 1.6.0
Signed-off-by: David Mehren <git@herrmehren.de>
|
|\
| |
| | |
Fix insertOnStartOfLines behaviour
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
A bug in insertOnStartOfLines lead to duplicated text,
if the cursor was not at the start of a line.
This fixes the behaviour of insertOnStartOfLines to always use
the complete first and last line of the selection,
even if they were only partially selected.
Fixes #1231
Signed-off-by: David Mehren <git@herrmehren.de>
|
|/
|
|
|
|
|
| |
The regex for tasklists in 1.x didn't include upper-case x/X letters nor ordered lists (1. [ ] abc).
This commit changes the regex to allow both.
Signed-off-by: Erik Michelson <opensource@erik.michelson.eu>
|
|
|
|
| |
Signed-off-by: David Mehren <git@herrmehren.de>
|
|
|
|
| |
Signed-off-by: Erik Michelson <github@erik.michelson.eu>
|
|
|
|
| |
Signed-off-by: David Mehren <git@herrmehren.de>
|
|
|
|
|
|
| |
New languages: bg, fa, gl, he, hu, oc, pt-br
Signed-off-by: David Mehren <git@herrmehren.de>
|
|
|
|
| |
Signed-off-by: David Mehren <git@herrmehren.de>
|
|\ |
|
| |
| |
| |
| | |
Signed-off-by: David Mehren <git@herrmehren.de>
|
|\ \
| |/
|/| |
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
As Node 10 will be EOL at April 30th, we should stop supporting
and/or promoting the usage of that version.
See also https://endoflife.date/nodejs
Signed-off-by: David Mehren <git@herrmehren.de>
|
|/
|
|
| |
Signed-off-by: Philip Molares <philip.molares@udo.edu>
|
|
|
|
|
|
|
| |
Explain tags in the features.md with yaml metadata, instead of the
heading syntax.
Signed-off-by: Philip Molares <philip.molares@udo.edu>
|
|\
| |
| | |
[1.x] Templates: Remove lang and add translation parameter
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Since the interface is not always in english, we mostly removed the lang attribute from all html tags. Since the error messages in error.ejs are not translated, but always in english, there the global lang="en" should be kept.
Also in the slide and editor template the div, which contains the user generated text, has the attribute translate="no" now, to avoid unwanted translations.
Since on the publish view (pretty.ejs) only the user generated content is shown, we set the lang to the language defined in yaml (or 'en') as a default, but that was also moved to the corresponding markdown div instead of html.
Fixes #881
See also #437
Signed-off-by: Philip Molares <philip.molares@udo.edu>
|
|/
|
|
| |
Signed-off-by: David Mehren <git@herrmehren.de>
|
|
|
|
|
|
|
|
|
|
| |
jQuery's .html() method escapes contained text (e.g. '<' becomes
'<'). This confuses the turndown parser, which then only performs
unescaping, but does not convert to markdown.
By using .text() instead, the unescaped content is returned and turndown
can correctly generate markdown.
Signed-off-by: David Mehren <git@herrmehren.de>
|
|
|
|
| |
Signed-off-by: Philip Molares <philip.molares@udo.edu>
|
|\ |
|
| |
| |
| |
| | |
Signed-off-by: David Mehren <git@herrmehren.de>
|
|/
|
|
| |
Signed-off-by: David Mehren <git@herrmehren.de>
|
|
|
|
|
|
|
|
|
|
| |
If the slide options in the frontmatter are empty
or not present, then slideOptions object in the
parsed JSON is undefined. This triggers an
exception when the sanitized slide options object
is built.
Signed-off-by: Tilman Vatteroth <tilman.vatteroth@tu-dortmund.de>
|
|
|
|
|
|
| |
A general invert-filter is applied to all pre elements in night mode. As diagrams are embedded inside pre tags, they're inverted as well. For sequence-diagrams and flow-charts this looks well, if we wouldn't additionally set the stroke and text color to white in night-mode. These additional white rules invert the already inverted diagram again and make it not good visible. The graphviz and abc embeddings aren't really optimized to be inverted, therefore they're now excluded from invertion and stay in day mode.
Signed-off-by: Erik Michelson <github@erik.michelson.eu>
|
|
|
|
|
|
|
|
| |
Reveal.js doesn't set the default value of an option in the provided config object
if the key is set with "undefined" as value. This leads to a broken slide mode,
because some critical settings are missing.
Signed-off-by: Tilman Vatteroth <tilman.vatteroth@tu-dortmund.de>
|
|
|
|
| |
Signed-off-by: David Mehren <git@herrmehren.de>
|
|\ |
|
| |
| |
| |
| | |
Signed-off-by: Philip Molares <philip.molares@udo.edu>
|
| |
| |
| |
| |
| |
| | |
this was suggested by @TobiasHoll in https://github.com/hackmdio/codimd/issues/1648
Signed-off-by: Philip Molares <philip.molares@udo.edu>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This should prevent the issue mentioned in https://github.com/hackmdio/codimd/issues/1648
Specifically left out are
- dependency (user can't really include anything anyway, because CSP forbids most domains)
- autoSlideMethod (nothing our users should be able to change as they won't write JS to be affected by this)
- keyboard (this let's users write arbitrary code and seems therefore to problematic)
See:
https://github.com/hakimel/reveal.js/blob/3.9.2/README.md#configuration
Signed-off-by: Philip Molares <philip.molares@udo.edu>
|
|/
|
|
|
|
|
|
|
|
| |
can't be moved without changing the note.
Thanks to @mhdrone for reporting this and suggesting the fix
fixes #724
Signed-off-by: Philip Molares <philip.molares@udo.edu>
|
|
|
|
| |
Signed-off-by: David Mehren <git@herrmehren.de>
|
|
|
|
| |
Signed-off-by: David Mehren <git@herrmehren.de>
|
|
|
|
|
|
|
| |
Using jQuery's `.html()` method stores the given string as `innerHTML`, which enables injection of arbitrary DOM elements.
Using `.text()` instead mitigates this issue.
Signed-off-by: David Mehren <git@herrmehren.de>
|
|
|
|
|
|
| |
This header needs to be set correctly if the reverse proxy terminates TLS, otherwise we don't send cookies.
Signed-off-by: David Mehren <git@herrmehren.de>
|
|
|
|
| |
Signed-off-by: David Mehren <git@herrmehren.de>
|
|
|
|
| |
Signed-off-by: David Mehren <git@herrmehren.de>
|
|
|
|
| |
Signed-off-by: David Mehren <git@herrmehren.de>
|
|
|
|
| |
Signed-off-by: David Mehren <git@herrmehren.de>
|
|\
| |
| | |
Fix shortcut icon urls pointing to old (nonexistent) files
|
| |
| |
| |
| | |
Signed-off-by: Erik Michelson <github@erik.michelson.eu>
|
|\ \
| | |
| | | |
Replace references to Matrix room with chat.hedgedoc.org
|
| | |
| | |
| | |
| | | |
Signed-off-by: David Mehren <git@herrmehren.de>
|
|/ /
| |
| |
| |
| |
| | |
This was missed in #596 and breaks the frontend JS.
Signed-off-by: David Mehren <git@herrmehren.de>
|
|/
|
|
| |
Signed-off-by: Tilman Vatteroth <tilman.vatteroth@tu-dortmund.de>
|
|
|
|
| |
Signed-off-by: Tilman Vatteroth <tilman.vatteroth@tu-dortmund.de>
|