| Commit message (Collapse) | Author | Age | Files | Lines |
|\
| |
| | |
Automatically generate a session secret if default is used
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
The session secret is used to sign and authenticate the session cookie
and this way very important for the authentication process.
By default the session secret is set to `secret` and never changes. This
commit will add a generator for a dynamic session secret if it stays
unchanged.
It prevents session hijacking this way and will warn the user about
the missing secret.
This also implies that on a restart without configured session secret
will log out all users. While it may seems annoying, it's for the users
best.
Signed-off-by: Sheogorath <sheogorath@shivering-isles.com>
|
|\ \
| | |
| | | |
Fix some issues with legacy config compatiblity
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
We should check for an undefined and not just for a logical true or
false.
Example: When `usecdn` was set to false it was impossible to overwrite
the new config value because the if statement becomes false.
Thanks @davidmehren for pointing me to this issue.
Signed-off-by: Sheogorath <sheogorath@shivering-isles.com>
|
| |/
| |
| |
| |
| |
| | |
Looks like we forgot something during the migration. This should fix it.
Signed-off-by: Sheogorath <sheogorath@shivering-isles.com>
|
|/
|
|
|
|
|
|
|
|
|
|
|
| |
Adding mediaSrc to CSP so video and audio files can be embedded without
problems.
From a security perspective it should be fine to load audio and video
data without introducing a high security issue. Only from a privacy
perspective it allows another way to track users if there are data
embedded. But it doesn't introduce any new attack vector as pictures are
also allowed from everywhere.
Signed-off-by: Sheogorath <sheogorath@shivering-isles.com>
|
|
|
|
|
|
|
|
| |
This refactors the configs a bit to now use camel case everywhere.
This change should help to clean up the config interface and make it
better understandable.
Signed-off-by: Sheogorath <sheogorath@shivering-isles.com>
|
|\
| |
| | |
Refactoring imageRouter to modularity
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This should make the imageRouter more modular and easier to extent. Also
a lot of code duplication was removed which should simplify maintenance
in future.
In the new setup we only need to provide a new module file which exports
a function called `uploadImage` and takes a filePath and a callback as
argument. The callback itself takes an error and an url as parameter.
This eliminates the need of a try-catch-block around the statement and
re-enabled the optimization in NodeJS.
Signed-off-by: Sheogorath <sheogorath@shivering-isles.com>
|
|\ \
| | |
| | | |
Add check for undefined UUID
|
| |/
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This check is needed at there are tons of LDAP implementations out there
and none has at least one guaranteed unique field. As we currently check
three fields and added an option to select one yourself, it's still not
said that any of these fields is set. This will now create an error
and fail the authentication instead of letting people may get access to
other people's notes which are stored under a this way deterministic
wrong userid named `LDAP-undefined`.
Signed-off-by: Sheogorath <sheogorath@shivering-isles.com>
|
|\ \
| | |
| | | |
Fix to use url-safe base64 in note url
|
| | |
| | |
| | |
| | | |
Signed-off-by: Max Wu <jackymaxj@gmail.com>
|
| | |
| | |
| | |
| | |
| | |
| | | |
that LZString note url could be parsed by base64url note url and thus return wrong note id
Signed-off-by: Max Wu <jackymaxj@gmail.com>
|
| | |
| | |
| | |
| | | |
Signed-off-by: Max Wu <jackymaxj@gmail.com>
|
| | |
| | |
| | |
| | | |
Signed-off-by: Max Wu <jackymaxj@gmail.com>
|
| | |
| | |
| | |
| | | |
Signed-off-by: Max Wu <jackymaxj@gmail.com>
|
| | |
| | |
| | |
| | | |
Signed-off-by: Max Wu <jackymaxj@gmail.com>
|
|\ \ \
| | | |
| | | | |
Add missing migration for permissions
|
| | | |
| | | |
| | | |
| | | | |
Signed-off-by: Sheogorath <sheogorath@shivering-isles.com>
|
| |_|/
|/| |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
As minio causes various problem if you configure it using environment
variables and leave the port setting out, which will evaluate to NaN,
this change should fix this in a clean way for this time and helps to
support numbers in general in future.
Signed-off-by: Sheogorath <sheogorath@shivering-isles.com>
|
|\ \ \
| | | |
| | | | |
Add config option for report URI in CSP
|
| |/ /
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This option is needed as it's currently not possible to add an report
URI by the directives array. This option also allows to get CSP reports
not only on docker based setup but also on our heroku instances.
Signed-off-by: Sheogorath <sheogorath@shivering-isles.com>
|
| | |
| | |
| | |
| | |
| | | |
fix hackmdio/hackmd#763
Signed-off-by: Tang TsungYi <vazontang@gmail.com>
|
|/ /
| |
| |
| | |
Signed-off-by: Felix Schäfer <felix@thegcat.net>
|
| |
| |
| |
| |
| |
| | |
hackmdio/hackmd#754
Signed-off-by: Felix Schäfer <felix@thegcat.net>
|
|/
|
|
| |
Signed-off-by: Dustin Frisch <fooker@lab.sh>
|
|
|
|
| |
Signed-off-by: Max Wu <jackymaxj@gmail.com>
|
|
|
|
| |
* Fix field type to prevent data truncation of authorship
|
|
|
|
| |
Signed-off-by: Takeaki Matsumoto <takeaki.matsumoto@ntt.com>
|
|
|
|
| |
Signed-off-by: Stefan Bühler <buehler@cert.uni-stuttgart.de>
|
|
|
|
|
|
|
| |
Since we added user management it's possible to get non-existent users
which can cause a crash of the Backend server.
Signed-off-by: Sheogorath <sheogorath@shivering-isles.com>
|
|\
| |
| | |
Fix ldap provider name in template
|
| |
| |
| |
| |
| |
| |
| |
| | |
Before this fix it's impossible to set the provider name in the
sign-model since `ldap` is a boolean there and this way not able
to have an attribute like `ldap.providerName`.
Signed-off-by: Sheogorath <sheogorath@shivering-isles.com>
|
|/
|
|
|
|
|
|
|
|
|
|
|
| |
This removes the only camel cased option of the config options
**we** added to the config.json.
In auth provider's config parts are a lot of camel cased options
provided. We shouldn't touch them to keep them as similar as
possible to the examples.
Fixes #315
Signed-off-by: Sheogorath <sheogorath@shivering-isles.com>
|
|\
| |
| | |
Allow more detailed configuration of upload mime types
|
| |
| |
| |
| |
| |
| | |
Fixes #637
Signed-off-by: Sheogorath <sheogorath@shivering-isles.com>
|
| |
| |
| |
| | |
Signed-off-by: Sheogorath <sheogorath@shivering-isles.com>
|
|\ \
| | |
| | | |
Add support for minio
|
| | | |
|
|\ \ \
| | | |
| | | | |
Implement basic CSP support
|
| | | |
| | | |
| | | |
| | | | |
Not sure why I was quoting these in the first place
|
| | | | |
|
| | | | |
|
| | | | |
|
| | | |
| | | |
| | | |
| | | | |
Config option; default is to only upgrade if usessl
|
| | | | |
|
|\ \ \ \
| | | | |
| | | | | |
Allow posting new note with content
|
| | | | |
| | | | |
| | | | |
| | | | | |
Signed-off-by: Dustin Frisch <fooker@lab.sh>
|
| |_|_|/
|/| | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Before, closed disallowed guest edits completely, by removing
the `freely` permission. This makes it possible to explicitely bring
back guest-editing, but not guest-note-creation, to closed instances.
Signed-off-by: Dario Ernst <dario@kanojo.de>
|