summaryrefslogtreecommitdiff
path: root/public/js/lib/common
diff options
context:
space:
mode:
authorSheogorath2020-06-10 12:21:11 +0200
committerSheogorath2020-06-10 12:26:23 +0200
commit8cf3b50ee9108e06d7c9a0aac78b4fffa4ef4453 (patch)
tree895e6e535935c9f582f4b950c166c42d9ad784d8 /public/js/lib/common
parentd6ce60c86e714b9835822e8539470b21b8fb823c (diff)
Fix broken cookie handling due to missing proxy awareness
We enabled the `secure` flag for various cookies in previous commits. This caused setups behind reverse proxies to drop cookies as the nodejs instance wasn't aware of the fact that it was able to hand out secure commits using an insecure connection (between the codimd instance and the reverse proxy). This patch makes express, the webserver framework we use, aware of proxies and this way re-enabled the handing out of cookies. Not only the cookie monster will enjoy, but also functionality like authentication and real-time editing will return as intended. References: https://www.npmjs.com/package/express-session#cookiesecure https://github.com/codimd/server/commit/383d791a50919bb9890a3f3f797ecc95125ab8bf Signed-off-by: Sheogorath <sheogorath@shivering-isles.com>
Diffstat (limited to '')
0 files changed, 0 insertions, 0 deletions