Refactoring imageRouter to modularity

This should make the imageRouter more modular and easier to extent. Also
a lot of code duplication was removed which should simplify maintenance
in future.

In the new setup we only need to provide a new module file which exports
a function called `uploadImage` and takes a filePath and a callback as
argument. The callback itself takes an error and an url as parameter.
This eliminates the need of a try-catch-block around the statement and
re-enabled the optimization in NodeJS.

Signed-off-by: Sheogorath <sheogorath@shivering-isles.com>

1 files changed, 50 insertions, 0 deletions

diff --git a/lib/web/imageRouter/s3.js b/lib/web/imageRouter/s3.js
new file mode 100644
index 00000000..bcd3ea60
--- /dev/null
+++ b/lib/web/imageRouter/s3.js
@@ -0,0 +1,50 @@
+'use strict'
+const fs = require('fs')
+const path = require('path')
+
+const config = require('../../config')
+const {getImageMimeType} = require('../../utils')
+
+const AWS = require('aws-sdk')
+const awsConfig = new AWS.Config(config.s3)
+const s3 = new AWS.S3(awsConfig)
+
+exports.uploadImage = function (imagePath, callback) {
+  if (!imagePath || typeof imagePath !== 'string') {
+    callback(new Error('Image path is missing or wrong'), null)
+    return
+  }
+
+  if (!callback || typeof callback !== 'function') {
+    callback(new Error('Callback has to be a function'), null)
+    return
+  }
+
+  fs.readFile(imagePath, function (err, buffer) {
+    if (err) {
+      callback(new Error(err), null)
+      return
+    }
+    let params = {
+      Bucket: config.s3bucket,
+      Key: path.join('uploads', path.basename(imagePath)),
+      Body: buffer
+    }
+
+    const mimeType = getImageMimeType(imagePath)
+    if (mimeType) { params.ContentType = mimeType }
+
+    s3.putObject(params, function (err, data) {
+      if (err) {
+        callback(new Error(err), null)
+        return
+      }
+
+      let s3Endpoint = 's3.amazonaws.com'
+      if (config.s3.region && config.s3.region !== 'us-east-1') {
+        s3Endpoint = `s3-${config.s3.region}.amazonaws.com`
+      }
+      callback(null, `https://${s3Endpoint}/${config.s3bucket}/${params.Key}`)
+    })
+  })
+}