Refactoring imageRouter to modularity

This should make the imageRouter more modular and easier to extent. Also
a lot of code duplication was removed which should simplify maintenance
in future.

In the new setup we only need to provide a new module file which exports
a function called `uploadImage` and takes a filePath and a callback as
argument. The callback itself takes an error and an url as parameter.
This eliminates the need of a try-catch-block around the statement and
re-enabled the optimization in NodeJS.

Signed-off-by: Sheogorath <sheogorath@shivering-isles.com>

1 files changed, 28 insertions, 0 deletions

diff --git a/lib/web/imageRouter/imgur.js b/lib/web/imageRouter/imgur.js
new file mode 100644
index 00000000..31d5f55c
--- /dev/null
+++ b/lib/web/imageRouter/imgur.js
@@ -0,0 +1,28 @@
+'use strict'
+const config = require('../../config')
+const logger = require('../../logger')
+
+const imgur = require('imgur')
+
+exports.uploadImage = function (imagePath, callback) {
+  if (!imagePath || typeof imagePath !== 'string') {
+    callback(new Error('Image path is missing or wrong'), null)
+    return
+  }
+
+  if (!callback || typeof callback !== 'function') {
+    callback(new Error('Callback has to be a function'), null)
+    return
+  }
+
+  imgur.setClientId(config.imgur.clientID)
+  imgur.uploadFile(imagePath)
+  .then(function (json) {
+    if (config.debug) {
+      logger.info('SERVER uploadimage success: ' + JSON.stringify(json))
+    }
+    callback(null, json.data.link.replace(/^http:\/\//i, 'https://'))
+  }).catch(function (err) {
+    callback(new Error(err), null)
+  })
+}