diff options
author | Sheogorath | 2018-03-18 02:14:50 +0100 |
---|---|---|
committer | Sheogorath | 2018-03-20 11:00:11 +0100 |
commit | 1756e76dc31495d03c8792fa672ae6bb94d24ea8 (patch) | |
tree | cc6e8a8e946458e152e81806a5e5a3079fcc138f /lib/web/imageRouter/filesystem.js | |
parent | 9cbe03d8a8eb503170b7b481e97c37d66447dd37 (diff) |
Refactoring imageRouter to modularity
This should make the imageRouter more modular and easier to extent. Also
a lot of code duplication was removed which should simplify maintenance
in future.
In the new setup we only need to provide a new module file which exports
a function called `uploadImage` and takes a filePath and a callback as
argument. The callback itself takes an error and an url as parameter.
This eliminates the need of a try-catch-block around the statement and
re-enabled the optimization in NodeJS.
Signed-off-by: Sheogorath <sheogorath@shivering-isles.com>
Diffstat (limited to 'lib/web/imageRouter/filesystem.js')
-rw-r--r-- | lib/web/imageRouter/filesystem.js | 18 |
1 files changed, 18 insertions, 0 deletions
diff --git a/lib/web/imageRouter/filesystem.js b/lib/web/imageRouter/filesystem.js new file mode 100644 index 00000000..25ec3846 --- /dev/null +++ b/lib/web/imageRouter/filesystem.js @@ -0,0 +1,18 @@ +'use strict' +const url = require('url') + +const config = require('../../config') + +exports.uploadImage = function (imagePath, callback) { + if (!imagePath || typeof imagePath !== 'string') { + callback(new Error('Image path is missing or wrong'), null) + return + } + + if (!callback || typeof callback !== 'function') { + callback(new Error('Callback has to be a function'), null) + return + } + + callback(null, url.resolve(config.serverurl + '/', imagePath.match(/^public\/(.+$)/)[1])) +} |