diff options
| author | Sheogorath | 2018-04-13 09:33:55 +0200 |
|---|---|---|
| committer | Sheogorath | 2018-04-13 09:38:59 +0200 |
| commit | ef86bf5cba65af3dc3db10944cec8d40d848daaa (patch) | |
| tree | 7d5973f44d35121e05cb90fd21906db1dd6c49a1 | |
| parent | f23f403bcb990a03fe27d5d4dda491c5de89c464 (diff) | |
Use API key instead of clientSecret
As recently discovered we send the clientSecret to the webclient which
is potentionally dangerous. This patch should fix the problem and
replace the clientSecret with the originally intended and correct way to
implement it using the API key.
Signed-off-by: Sheogorath <sheogorath@shivering-isles.com>
| -rw-r--r-- | app.js | 2 | ||||
| -rw-r--r-- | lib/config/default.js | 1 | ||||
| -rw-r--r-- | lib/config/environment.js | 1 |
3 files changed, 3 insertions, 1 deletions
@@ -33,7 +33,7 @@ var data = { urlpath: config.urlPath, debug: config.debug, version: config.version, - GOOGLE_API_KEY: config.google.clientSecret, + GOOGLE_API_KEY: config.google.apiKey, GOOGLE_CLIENT_ID: config.google.clientID, DROPBOX_APP_KEY: config.dropbox.appKey, allowedUploadMimeTypes: config.allowedUploadMimeTypes diff --git a/lib/config/default.js b/lib/config/default.js index 68849d36..db0c0362 100644 --- a/lib/config/default.js +++ b/lib/config/default.js @@ -104,6 +104,7 @@ module.exports = { appKey: undefined }, google: { + apiKey: undefined, clientID: undefined, clientSecret: undefined }, diff --git a/lib/config/environment.js b/lib/config/environment.js index 3dde4786..8e1e5171 100644 --- a/lib/config/environment.js +++ b/lib/config/environment.js @@ -74,6 +74,7 @@ module.exports = { appKey: process.env.HMD_DROPBOX_APPKEY }, google: { + apiKey: process.env.HMD_GOOGLE_APIKEY, clientID: process.env.HMD_GOOGLE_CLIENTID, clientSecret: process.env.HMD_GOOGLE_CLIENTSECRET }, |