summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorSheogorath2018-09-24 17:55:03 +0200
committerSheogorath2018-09-24 20:25:25 +0200
commit6fdb9eea4627fe23e24d487d0b855493178b8798 (patch)
treee727c24424aeb34d6e83e7e92c20b5b6ce9f0f25
parent32afa1437510fb55194c9532fced856f9a496eb0 (diff)
Fix server crash on PDF creation
`markdown-pdf` seems to fail to provide the PDFs on tmpfs. This leads crashing codimd which expects the file to be there. This patch should add some proper error handling when expectation and reality don't fit together. Signed-off-by: Sheogorath <sheogorath@shivering-isles.com>
-rw-r--r--lib/response.js4
1 files changed, 4 insertions, 0 deletions
diff --git a/lib/response.js b/lib/response.js
index 37211998..295f91d6 100644
--- a/lib/response.js
+++ b/lib/response.js
@@ -341,6 +341,10 @@ function actionPDF (req, res, note) {
var path = config.tmpPath + '/' + Date.now() + '.pdf'
content = content.replace(/\]\(\//g, '](' + url + '/')
markdownpdf().from.string(content).to(path, function () {
+ if (!fs.existsSync(path)) {
+ logger.error('PDF seems to not be generated as expected. File doesn\'t exist: ' + path)
+ return response.errorInternalError(res)
+ }
var stream = fs.createReadStream(path)
var filename = title
// Be careful of special characters