diff options
author | Christoph (Sheogorath) Kern | 2019-02-21 23:34:15 +0100 |
---|---|---|
committer | GitHub | 2019-02-21 23:34:15 +0100 |
commit | 5274247790daa023e4712b622b4e14a74d02805a (patch) | |
tree | 362517e6b2639f944e6bc7386beef9a9f055df5f | |
parent | 0d887074758909488981f8399ede2d362ed189a9 (diff) | |
parent | 1f0fb127555ac80826e573a187a4232668323804 (diff) |
Merge pull request #1150 from SISheogorath/fix/speakerdeck
Remove broken speakerdeck embedding
Diffstat (limited to '')
-rw-r--r-- | public/docs/features.md | 3 | ||||
-rw-r--r-- | public/js/extra.js | 35 | ||||
-rw-r--r-- | public/js/index.js | 5 |
3 files changed, 9 insertions, 34 deletions
diff --git a/public/docs/features.md b/public/docs/features.md index a4ffb633..e7ce89ce 100644 --- a/public/docs/features.md +++ b/public/docs/features.md @@ -222,9 +222,6 @@ When you’re a carpenter making a beautiful chest of drawers, you’re not goin ### SlideShare {%slideshare briansolis/26-disruptive-technology-trends-2016-2018-56796196 %} -### Speakerdeck -{%speakerdeck sugarenia/xxlcss-how-to-scale-css-and-keep-your-sanity %} - ### PDF **Caution: this might be blocked by your browser if not using an `https` URL.** {%pdf https://papers.nips.cc/paper/5346-sequence-to-sequence-learning-with-neural-networks.pdf %} diff --git a/public/js/extra.js b/public/js/extra.js index 76e95635..f8e0eb22 100644 --- a/public/js/extra.js +++ b/public/js/extra.js @@ -459,34 +459,13 @@ export function finishView (view) { // speakerdeck view.find('div.speakerdeck.raw').removeClass('raw') .each((key, value) => { - const url = `https://speakerdeck.com/oembed.json?url=https%3A%2F%2Fspeakerdeck.com%2F${encodeURIComponent($(value).attr('data-speakerdeckid'))}` - // use yql because speakerdeck not support jsonp - $.ajax({ - url: 'https://query.yahooapis.com/v1/public/yql', - data: { - q: `select * from json where url ='${url}'`, - format: 'json' - }, - dataType: 'jsonp', - success (data) { - if (!data.query || !data.query.results) return - const json = data.query.results.json - const html = json.html - var ratio = json.height / json.width - $(value).html(html) - const iframe = $(value).children('iframe') - const src = iframe.attr('src') - if (src.indexOf('//') === 0) { iframe.attr('src', `https:${src}`) } - const inner = $('<div class="inner"></div>').append(iframe) - const height = iframe.attr('height') - const width = iframe.attr('width') - ratio = (height / width) * 100 - inner.css('padding-bottom', `${ratio}%`) - $(value).html(inner) - if (window.viewAjaxCallback) window.viewAjaxCallback() - } - }) - }) + const url = `https://speakerdeck.com/${$(value).attr('data-speakerdeckid')}` + const inner = $('<a>Speakerdeck</a>') + inner.attr('href', url) + inner.attr('rel', 'noopener noreferrer') + inner.attr('target', '_blank') + $(value).append(inner) + }) // pdf view.find('div.pdf.raw').removeClass('raw') .each(function (key, value) { diff --git a/public/js/index.js b/public/js/index.js index a845b5d3..76f952c1 100644 --- a/public/js/index.js +++ b/public/js/index.js @@ -1,7 +1,6 @@ /* eslint-env browser, jquery */ -/* global CodeMirror, Cookies, moment, editor, ui, Spinner, - modeType, Idle, serverurl, key, gapi, Dropbox, FilePicker - ot, MediaUploader, hex2rgb, num_loaded, Visibility */ +/* global CodeMirror, Cookies, moment, Spinner, Idle, serverurl, + key, Dropbox, ot, hex2rgb, Visibility */ require('../vendor/showup/showup') |