diff options
| author | Nadrieril | 2020-04-11 22:05:00 +0100 |
|---|---|---|
| committer | Nadrieril | 2020-06-25 15:12:09 +0100 |
| commit | 9da112a1985124f549254943c81495e637fb43cc (patch) | |
| tree | abd25710687e95a2d5f78ab69ba13a9a1ef31edb /dhall | |
| parent | 72ad56209fe10e3120c19ca5b820ff267423ab1d (diff) | |
spec: allow unions with mixed kinds
Diffstat (limited to 'dhall')
8 files changed, 5 insertions, 57 deletions
diff --git a/dhall/src/semantics/tck/typecheck.rs b/dhall/src/semantics/tck/typecheck.rs index 361e1b4..d21c7ce 100644 --- a/dhall/src/semantics/tck/typecheck.rs +++ b/dhall/src/semantics/tck/typecheck.rs @@ -137,30 +137,20 @@ fn type_one_layer( Type::from_const(k) } ExprKind::UnionType(kts) => { - // Check that all types are the same const - let mut k = None; + // An empty union type has type Type; + // an union type with only unary variants also has type Type + let mut k = Const::Type; for t in kts.values() { if let Some(t) = t { - let c = match t.ty().as_const() { - Some(c) => c, + match t.ty().as_const() { + Some(c) => k = max(k, c), None => { return mk_span_err(t.span(), "InvalidVariantType") } - }; - match k { - None => k = Some(c), - Some(k) if k == c => {} - _ => { - return mk_span_err(t.span(), "InvalidVariantType") - } } } } - // An empty union type has type Type; - // an union type with only unary variants also has type Type - let k = k.unwrap_or(Const::Type); - Type::from_const(k) } ExprKind::Op(op) => typecheck_operation(env, span, op)?, diff --git a/dhall/tests/type-inference/failure/mixedUnions.txt b/dhall/tests/type-inference/failure/mixedUnions.txt deleted file mode 100644 index 2b307d0..0000000 --- a/dhall/tests/type-inference/failure/mixedUnions.txt +++ /dev/null @@ -1,6 +0,0 @@ -Type error: error: InvalidVariantType - --> <current file>:1:28 - | -1 | < Left : Natural | Right : Type > - | ^^^^ InvalidVariantType - | diff --git a/dhall/tests/type-inference/failure/unit/RecordMixedKinds3.txt b/dhall/tests/type-inference/failure/unit/RecordMixedKinds3.txt deleted file mode 100644 index a83bb4f..0000000 --- a/dhall/tests/type-inference/failure/unit/RecordMixedKinds3.txt +++ /dev/null @@ -1,6 +0,0 @@ -Type error: error: InvalidFieldType - --> <current file>:1:17 - | -1 | { x = Type, y = Kind } - | ^^^^ InvalidFieldType - | diff --git a/dhall/tests/type-inference/failure/unit/RightBiasedRecordMergeMixedKinds2.txt b/dhall/tests/type-inference/failure/unit/RightBiasedRecordMergeMixedKinds2.txt deleted file mode 100644 index 6a6da80..0000000 --- a/dhall/tests/type-inference/failure/unit/RightBiasedRecordMergeMixedKinds2.txt +++ /dev/null @@ -1,6 +0,0 @@ -Type error: error: InvalidFieldType - --> <current file>:1:22 - | -1 | { x = Bool } ⫽ { x = Kind } - | ^^^^ InvalidFieldType - | diff --git a/dhall/tests/type-inference/failure/unit/RightBiasedRecordMergeMixedKinds3.txt b/dhall/tests/type-inference/failure/unit/RightBiasedRecordMergeMixedKinds3.txt deleted file mode 100644 index 322e7f4..0000000 --- a/dhall/tests/type-inference/failure/unit/RightBiasedRecordMergeMixedKinds3.txt +++ /dev/null @@ -1,6 +0,0 @@ -Type error: error: InvalidFieldType - --> <current file>:1:21 - | -1 | { x = {=} } ⫽ { x = Kind } - | ^^^^ InvalidFieldType - | diff --git a/dhall/tests/type-inference/failure/unit/UnionTypeMixedKinds.txt b/dhall/tests/type-inference/failure/unit/UnionTypeMixedKinds.txt deleted file mode 100644 index ae6c845..0000000 --- a/dhall/tests/type-inference/failure/unit/UnionTypeMixedKinds.txt +++ /dev/null @@ -1,6 +0,0 @@ -Type error: error: InvalidVariantType - --> <current file>:1:18 - | -1 | < x : Bool | y : Type > - | ^^^^ InvalidVariantType - | diff --git a/dhall/tests/type-inference/failure/unit/UnionTypeMixedKinds2.txt b/dhall/tests/type-inference/failure/unit/UnionTypeMixedKinds2.txt deleted file mode 100644 index faf81a9..0000000 --- a/dhall/tests/type-inference/failure/unit/UnionTypeMixedKinds2.txt +++ /dev/null @@ -1,6 +0,0 @@ -Type error: error: InvalidVariantType - --> <current file>:1:18 - | -1 | < x : Kind | y : Type > - | ^^^^ InvalidVariantType - | diff --git a/dhall/tests/type-inference/failure/unit/UnionTypeMixedKinds3.txt b/dhall/tests/type-inference/failure/unit/UnionTypeMixedKinds3.txt deleted file mode 100644 index bbfb1f3..0000000 --- a/dhall/tests/type-inference/failure/unit/UnionTypeMixedKinds3.txt +++ /dev/null @@ -1,6 +0,0 @@ -Type error: error: InvalidVariantType - --> <current file>:1:18 - | -1 | < x : Kind | y : Bool > - | ^^^^ InvalidVariantType - | |