{-# LANGUAGE DataKinds #-} {-# LANGUAGE LambdaCase #-} {-# LANGUAGE MultiWayIf #-} {-# LANGUAGE NamedFieldPuns #-} {-# LANGUAGE OverloadedStrings #-} {-# LANGUAGE RecordWildCards #-} {-# LANGUAGE TypeApplications #-} -- | Contains checks for custom ties of the map json module Properties (checkMap, checkTileset, checkLayer) where import Control.Monad (forM_, unless, when) import Data.Text (Text, intercalate, isPrefixOf) import qualified Data.Text as T import qualified Data.Vector as V import Tiled (Layer (..), Object (..), Property (..), PropertyValue (..), Tile (..), Tiledmap (..), Tileset (..)) import TiledAbstract (HasName (..), HasProperties (..), HasTypeName (..), IsProperty (..)) import Util (layerIsEmpty, mkProxy, naiveEscapeHTML, prettyprint, showText) import Badges (Badge (Badge), BadgeArea (BadgePoint, BadgeRect), BadgeToken, parseToken) import Data.Data (Proxy (Proxy)) import Data.Functor ((<&>)) import Data.List ((\\)) import Data.Maybe (fromMaybe, isJust) import Data.Set (Set) import qualified Data.Set as S import GHC.TypeLits (KnownSymbol) import LayerData (Collision, layerOverlaps) import LintConfig (LintConfig (..)) import LintWriter (LintWriter, adjust, askContext, askFileDepth, complain, dependsOn, forbid, lintConfig, offersBadge, offersEntrypoint, suggest, warn) import Paths (PathResult (..), RelPath (..), getExtension, isOldStyle, parsePath) import Types (Dep (Link, Local, LocalMap, MapLink)) import Uris (SubstError (..), applySubst) -- | Checks an entire map for "general" lints. -- -- Note that it does /not/ check any tile layer/tileset properties; -- these are handled seperately in CheckMap, since these lints go -- into a different field of the output. checkMap :: LintWriter Tiledmap checkMap = do tiledmap <- askContext let layers = collectLayers tiledmap let unlessLayer = unlessElement layers -- test custom map properties mapM_ checkMapProperty (fromMaybe mempty $ tiledmapProperties tiledmap) -- can't have these with the rest of layer/tileset lints since they're -- not specific to any one of them refuseDoubledNames layers refuseDoubledNames (tiledmapTilesets tiledmap) refuseDoubledNames (getProperties tiledmap) -- some layers should exist unlessElementNamed layers "start" $ complain "The map must have one layer named \"start\"." unlessLayer (\l -> getName l == "floorLayer" && layerType l == "objectgroup") $ complain "The map must have one layer named \"floorLayer\" of type \"objectgroup\"." unlessLayer (`containsProperty` "exitUrl") $ complain "The map must contain at least one layer with the property \"exitUrl\" set." -- reject maps not suitable for workadventure unless (tiledmapOrientation tiledmap == "orthogonal") $ complain "The map's orientation must be set to \"orthogonal\"." unless (tiledmapTileheight tiledmap == 32 && tiledmapTilewidth tiledmap == 32) $ complain "The map's tile size must be 32 by 32 pixels." unlessHasProperty "mapCopyright" $ suggest "document the map's copyright via the \"mapCopyright\" property." -- TODO: this doesn't catch collisions with the default start layer! whenLayerCollisions layers (\(Property name _) -> name == "exitUrl" || name == "startLayer") $ \cols -> warn $ "collisions between entry and / or exit layers: " <> prettyprint cols let missingMetaInfo = ["mapName","mapDescription","mapLink"] \\ fmap getName (getProperties tiledmap) unless (null missingMetaInfo) $ suggest $ "consider adding meta information to your map using the " <> prettyprint missingMetaInfo <> " properties." where -- recursively find all layers (to deal with nested group layers) collectLayers :: Tiledmap -> V.Vector Layer collectLayers tiledmap = tiledmapLayers tiledmap <> V.fromList (concatMap groupmembers (tiledmapLayers tiledmap)) where groupmembers :: Layer -> [Layer] groupmembers layer = concatMap groupmembers layers <> layers where layers = fromMaybe [] $ layerLayers layer -- | Checks a single property of a map. checkMapProperty :: Property -> LintWriter Tiledmap checkMapProperty p@(Property name _) = case name of "mapName" -> naiveEscapeProperty p "mapDescription" -> naiveEscapeProperty p "mapCopyright" -> naiveEscapeProperty p "mapLink" -> pure () -- usually the linter will complain if names aren't in their -- "canonical" form, but allowing that here so that multiple -- scripts can be used by one map _ | T.toLower name == "script" -> unwrapString p $ \str -> unless ("https://static.rc3.world/scripts" `isPrefixOf` str) $ forbid "only scripts hosted on static.rc3.world are allowed." | name `elem` ["jitsiRoom", "bbbRoom", "playAudio", "openWebsite" , "url", "exitUrl", "silent", "getBadge"] -> complain $ "property " <> name <> " should be set on layers, not the map directly" | otherwise -> complain $ "unknown map property " <> prettyprint name -- | check an embedded tile set. -- -- Important to collect dependency files checkTileset :: LintWriter Tileset checkTileset = do tileset <- askContext unwrapPath (tilesetImage tileset) (dependsOn . Local) refuseDoubledNames (getProperties tileset) -- reject tilesets unsuitable for workadventure unless (tilesetTilewidth tileset == 32 && tilesetTileheight tileset == 32) $ complain "Tilesets must have tile size 32×32." unless (tilesetImageheight tileset < 4096 && tilesetImagewidth tileset < 4096) $ warn "Tilesets should not be larger than 4096x4096 pixels in total." when (isJust (tilesetSource tileset)) $ complain "Tilesets must be embedded and cannot be loaded from external files." unlessHasProperty "tilesetCopyright" $ forbid "property \"tilesetCopyright\" for tilesets must be set." when (isJust (tilesetFileName tileset)) $ complain "The \"filename\" property on tilesets was removed; use \"image\" instead (and perhaps a newer version of the Tiled Editor)." -- check individual tileset properties mapM_ checkTilesetProperty (fromMaybe mempty $ tilesetProperties tileset) case tilesetTiles tileset of Nothing -> pure () Just tiles -> do -- can't set properties on the same tile twice refuseDoubledThings tileId (\tile -> complain $ "cannot set properties on the \ \tile with the id" <> showText (tileId tile) <> "twice.") tiles mapM_ checkTile tiles where checkTilesetProperty :: Property -> LintWriter Tileset checkTilesetProperty p@(Property name _value) = case name of "tilesetCopyright" -> naiveEscapeProperty p _ -> warn $ "unknown tileset property " <> prettyprint name checkTile :: Tile -> LintWriter Tileset checkTile tile = do refuseDoubledNames (getProperties tile) mapM_ checkTileProperty (getProperties tile) where checkTileProperty :: Property -> LintWriter Tileset checkTileProperty p@(Property name _) = case name of "collides" -> isBool p _ -> warn $ "unknown tile property " <> prettyprint name <> " in tile with global id " <> showText (tileId tile) -- | collect lints on a single map layer checkLayer :: LintWriter Layer checkLayer = do layer <- askContext refuseDoubledNames (getProperties layer) when (isJust (layerImage layer)) $ complain "imagelayer are not supported." case layerType layer of "tilelayer" -> mapM_ checkTileLayerProperty (getProperties layer) "group" -> pure () "objectgroup" -> do -- all objects which don't define badges publicObjects <- askContext <&> fmap (V.filter (not . (`containsProperty` "getBadge"))) . layerObjects -- remove badges from output adjust $ \l -> l { layerObjects = publicObjects , layerProperties = Nothing } -- check object properties forM_ (fromMaybe mempty (layerObjects layer)) $ \object -> do mapM_ (checkObjectProperty object) (getProperties object) -- check layer properties forM_ (getProperties layer) checkObjectGroupProperty unless (layerName layer == "floorLayer") $ when (null (layerObjects layer) || layerObjects layer == Just mempty) $ warn "objectgroup layer (which aren't the floorLayer) \ \are useless if they are empty." ty -> complain $ "unsupported layer type " <> prettyprint ty <> "." if layerType layer == "group" then when (null (layerLayers layer)) $ warn "Empty group layers are pointless." else when (isJust (layerLayers layer)) $ complain "Layer is not of type \"group\", but has sublayers." checkObjectProperty :: Object -> Property -> LintWriter Layer checkObjectProperty obj p@(Property name _) = case name of "url" -> unwrapURI (Proxy @"website") p (dependsOn . Link) (const $ forbid "using \"url\" to open local html files is disallowed.") "allowApi" -> forbidProperty name "getBadge" -> do when (1 /= length (getProperties obj)) $ warn "Objects with the property \"getBadge\" set are removed at runtime, \ \and any other properties set on them will be gone." unwrapString p $ \str -> unwrapBadgeToken str $ \token -> do case obj of ObjectPolygon {} -> complain "polygons are not supported." ObjectPolyline {} -> complain "polylines are not supported." ObjectText {} -> complain "cannot use texts to define badge areas." ObjectRectangle {..} -> if objectEllipse == Just True then complain "ellipses are not supported." else offersBadge $ Badge token $ case (objectWidth, objectHeight) of (Just w, Just h) | w /= 0 && h /= 0 -> BadgeRect objectX objectY w h _ -> BadgePoint objectX objectY _ -> warn $ "unknown object property " <> prettyprint name <> "." -- | Checks a single (custom) property of an objectgroup layer checkObjectGroupProperty :: Property -> LintWriter Layer checkObjectGroupProperty (Property name _) = warn $ "unknown property " <> prettyprint name <> " for objectgroup layers" -- | Checks a single (custom) property of a "normal" tile layer checkTileLayerProperty :: Property -> LintWriter Layer checkTileLayerProperty p@(Property name _value) = case name of "jitsiRoom" -> do lintConfig configAssemblyTag >>= setProperty "jitsiRoomAdminTag" . ("assembly-" <>) -- prepend "assembly-" to avoid namespace clashes uselessEmptyLayer unwrapString p $ \jitsiRoom -> do suggestProperty $ Property "jitsiTrigger" "onaction" -- prepend jitsi room names to avoid name clashes unless ("shared-" `isPrefixOf` jitsiRoom) $ do assemblyname <- lintConfig configAssemblyTag setProperty "jitsiRoom" (assemblyname <> "-" <> jitsiRoom) "jitsiTrigger" -> do isString p unlessHasProperty "jitsiTriggerMessage" $ suggest "set \"jitsiTriggerMessage\" to a custom message to overwrite \ \the default \"press SPACE to enter in jitsi meet room\"." requireProperty "jitsiRoom" "jitsiTriggerMessage" -> do isString p requireProperty "jitsiTrigger" "jitsiUrl" -> isForbidden "jitsiConfig" -> isForbidden "jitsiClientConfig" -> isForbidden "jitsiRoomAdminTag" -> isForbidden "jitsiInterfaceConfig" -> isForbidden "jitsiWidth" -> isIntInRange 0 100 p "bbbRoom" -> do removeProperty "bbbRoom" unwrapURI (Proxy @"bbb") p (\link -> do dependsOn (Link link) setProperty "openWebsite" link setProperty "silent" (BoolProp True) setProperty "openWebsitePolicy" ("fullscreen;camera;microphone;display-capture" :: Text) ) (const $ complain "property \"bbbRoom\" cannot be used with local links.") "bbbTrigger" -> do removeProperty "bbbTrigger" requireProperty "bbbRoom" unwrapString p (setProperty "openWebsiteTrigger") unlessHasProperty "bbbTriggerMessage" $ do setProperty "openWebsiteTriggerMessage" ("press SPACE to enter bbb room" :: Text) suggest "set \"bbbTriggerMessage\" to a custom message to overwrite the\ \default \"press SPACE to enter the bbb room\"" "bbbTriggerMessage" -> do removeProperty "bbbTriggerMessage" requireProperty "bbbRoom" unwrapString p (setProperty "openWebsiteTriggerMessage") "playAudio" -> do uselessEmptyLayer unwrapURI (Proxy @"audio") p (dependsOn . Link) (dependsOn . Local) "audioLoop" -> do isBool p requireProperty "playAudio" "playAudioLoop" -> deprecatedUseInstead "audioLoop" "audioVolume" -> do isOrdInRange unwrapFloat 0 1 p requireProperty "playAudio" "openWebsite" -> do uselessEmptyLayer suggestProperty $ Property "openWebsiteTrigger" (StrProp "onaction") unwrapURI (Proxy @"website") p (dependsOn . Link) (const $ forbid "using openWebsite to access local html files is disallowed.") "openWebsiteTrigger" -> do isString p requireProperty "openWebsite" unlessHasProperty "openWebsiteTriggerMessage" $ suggest "set \"openWebsiteTriggerMessage\" to a custom message to\ \overwrite the default \"press SPACE to open Website\"." "openWebsiteTriggerMessage" -> do isString p requireProperty "openWebsiteTrigger" "openWebsitePolicy" -> isForbidden "openWebsiteAllowApi" -> isForbidden "openTab" -> do isString p requireProperty "openWebsite" "url" -> complain "the property \"url\" defining embedded iframes must be \ \set on an object in an objectgroup layer." "allowApi" -> isForbidden "exitUrl" -> do forbidEmptyLayer unwrapURI (Proxy @"map") p (\link -> do dependsOn (MapLink link) setProperty "exitUrl" link ) $ \path -> let ext = getExtension path in if | isOldStyle path -> complain "Old-Style inter-repository links (using {}) \ \cannot be used at rC3 2021; please use world:// instead \ \(see howto.rc3.world)." | ext == "tmx" -> complain "Cannot use .tmx map format; use Tiled's json export instead." | ext /= "json" -> complain "All exit links must link to .json files." | otherwise -> dependsOn . LocalMap $ path "exitSceneUrl" -> deprecatedUseInstead "exitUrl" "exitInstance" -> deprecatedUseInstead "exitUrl" "startLayer" -> do forbidEmptyLayer layer <- askContext unwrapBool p $ \case True -> offersEntrypoint $ layerName layer False -> warn "property \"startLayer\" is useless if set to false." "silent" -> do isBool p uselessEmptyLayer -- "collides" -> -- unwrapBool p $ \case -- True -> pure () -- False -> warn "property \"collides\" set to 'false' is useless." "getBadge" -> complain "\"getBadge\" must be set on an \"objectgroup\" \ \ layer; it does not work on tile layers." "name" -> isUnsupported _ -> warn $ "unknown property type " <> prettyprint name where isForbidden = forbidProperty name requireProperty req = propertyRequiredBy req name isUnsupported = warn $ "property " <> name <> " is not (yet) supported by walint." deprecatedUseInstead instead = warn $ "property \"" <> name <> "\" is deprecated. Use \"" <> instead <> "\" instead." -- | this property can only be used on a layer that contains -- | at least one tile forbidEmptyLayer = do layer <- askContext when (layerIsEmpty layer) $ complain ("property " <> prettyprint name <> " should not be set on an empty layer.") -- | this layer is allowed, but also useless on a layer that contains no tiles uselessEmptyLayer = do layer <- askContext when (layerIsEmpty layer) $ warn ("property " <> prettyprint name <> " set on an empty layer is useless.") -- | refuse doubled names in everything that's somehow a collection of names refuseDoubledNames :: (HasName a, HasTypeName a) => (Foldable t, Functor t) => t a -> LintWriter b refuseDoubledNames = refuseDoubledThings getName (\thing -> complain $ "cannot use " <> typeName (mkProxy thing) <> " name " <> getName thing <> " multiple times.") -- | refuse doubled things via equality on after applying some function refuseDoubledThings :: (Eq a, Ord a, Foldable t, Functor t) => (a' -> a) -> (a' -> LintWriter b) -> t a' -> LintWriter b refuseDoubledThings f ifDouble things = foldr folding base things (mempty, mempty) where folding thing cont (seen, twice) | f thing `elem` seen && f thing `notElem` twice = do ifDouble thing cont (seen, S.insert (f thing) twice) | otherwise = cont (S.insert (f thing) seen, twice) base _ = pure () ---- General functions ---- unlessElement :: Foldable f => f a -> (a -> Bool) -> LintWriter b -> LintWriter b unlessElement things op = unless (any op things) unlessElementNamed :: (HasName a, Foldable f) => f a -> Text -> LintWriter b -> LintWriter b unlessElementNamed things name = unlessElement things ((==) name . getName) unlessHasProperty :: HasProperties a => Text -> LintWriter a -> LintWriter a unlessHasProperty name linter = askContext >>= \ctxt -> unlessElementNamed (getProperties ctxt) name linter -- | does this layer have the given property? containsProperty :: HasProperties a => a -> Text -> Bool containsProperty thing name = any (\(Property name' _) -> name' == name) (getProperties thing) -- | should the layers fulfilling the given predicate collide, then perform andthen. whenLayerCollisions :: V.Vector Layer -> (Property -> Bool) -> (Set Collision -> LintWriter a) -> LintWriter a whenLayerCollisions layers f andthen = do let collisions = layerOverlaps . V.filter (any f . getProperties) $ layers unless (null collisions) $ andthen collisions ----- Functions with concrete lint messages ----- -- | this property is forbidden and should not be used forbidProperty :: Text -> LintWriter Layer forbidProperty name = do forbid $ "property " <> prettyprint name <> " is disallowed." propertyRequiredBy :: HasProperties a => Text -> Text -> LintWriter a propertyRequiredBy req by = unlessHasProperty req $ complain $ "property " <> prettyprint req <> " is required by property " <> prettyprint by <> "." -- | suggest some value for another property if that property does not -- also already exist suggestProperty :: Property -> LintWriter Layer suggestProperty (Property name value) = unlessHasProperty name $ suggest $ "set property " <> prettyprint name <> " to \"" <> prettyprint value<>"\"." ---- Functions for adjusting the context ----- -- | set a property, overwriting whatever value it had previously setProperty :: (IsProperty prop, HasProperties ctxt) => Text -> prop -> LintWriter ctxt setProperty name value = adjust $ \ctxt -> flip adjustProperties ctxt $ \ps -> Just $ Property name (asProperty value) : filter sameName ps where sameName (Property name' _) = name /= name' removeProperty :: HasProperties ctxt => Text -> LintWriter ctxt removeProperty name = adjust $ \ctxt -> flip adjustProperties ctxt $ \ps -> Just $ filter (\(Property name' _) -> name' /= name) ps naiveEscapeProperty :: HasProperties a => Property -> LintWriter a naiveEscapeProperty prop@(Property name _) = unwrapString prop (setProperty name . naiveEscapeHTML) ---- "unwrappers" checking that a property has some type, then do something ---- -- | asserts that this property is a string, and unwraps it unwrapString :: Property -> (Text -> LintWriter a) -> LintWriter a unwrapString (Property name value) f = case value of StrProp str -> f str _ -> complain $ "type error: property " <> prettyprint name <> " should be of type string." -- | asserts that this property is a boolean, and unwraps it unwrapBool :: Property -> (Bool -> LintWriter a) -> LintWriter a unwrapBool (Property name value) f = case value of BoolProp b -> f b _ -> complain $ "type error: property " <> prettyprint name <> " should be of type bool." unwrapInt :: Property -> (Int -> LintWriter a) -> LintWriter a unwrapInt (Property name value) f = case value of IntProp float -> f float _ -> complain $ "type error: property " <> prettyprint name <> " should be of type int." unwrapFloat :: Property -> (Float -> LintWriter a) -> LintWriter a unwrapFloat (Property name value) f = case value of FloatProp float -> f float _ -> complain $ "type error: property " <> prettyprint name <> " should be of type float." unwrapPath :: Text -> (RelPath -> LintWriter a) -> LintWriter a unwrapPath str f = case parsePath str of OkRelPath p@(Path up _ _) -> do depth <- askFileDepth if up <= depth then f p else complain $ "cannot acess paths \"" <> str <> "\" which is outside your repository." NotAPath -> complain $ "path \"" <> str <> "\" is invalid." AbsolutePath -> forbid "absolute paths are disallowed. Use world:// instead." UnderscoreMapLink -> forbid "map links using /_/ are disallowed. Use world:// instead." AtMapLink -> forbid "map links using /@/ are disallowed. Use world:// instead." PathVarsDisallowed -> forbid "extended API variables are not allowed in asset paths." unwrapBadgeToken :: Text -> (BadgeToken -> LintWriter a) -> LintWriter a unwrapBadgeToken str f = case parseToken str of Just a -> f a Nothing -> complain "invalid badge token." unwrapURI :: (KnownSymbol s, HasProperties a) => Proxy s -> Property -> (Text -> LintWriter a) -> (RelPath -> LintWriter a) -> LintWriter a unwrapURI sym p@(Property name _) f g = unwrapString p $ \link -> do subst <- lintConfig configUriSchemas case applySubst sym subst link of Right uri -> do setProperty name uri f uri Left NotALink -> unwrapPath link g Left err -> complain $ case err of IsBlocked -> link <> " is a blocked site." DomainDoesNotExist domain -> "The domain " <> domain <> " does not exist; \ \please make sure it is spelled correctly." SchemaDoesNotExist schema -> "the URI schema " <> schema <> ":// does not exist." WrongScope schema allowed -> "the URI schema " <> schema <> ":// cannot be used in property \ \\"" <> name <> "\"; allowed " <> (if length allowed == 1 then "is " else "are ") <> intercalate ", " (fmap (<> "://") allowed) <> "." VarsDisallowed -> "extended API links are disallowed in links" -- | just asserts that this is a string isString :: Property -> LintWriter a isString = flip unwrapString (const $ pure ()) -- | just asserts that this is a boolean isBool :: Property -> LintWriter a isBool = flip unwrapBool (const $ pure ()) isIntInRange :: Int -> Int -> Property -> LintWriter b isIntInRange = isOrdInRange @Int unwrapInt isOrdInRange :: (Ord a, Show a) => (Property -> (a -> LintWriter b) -> LintWriter b) -> a -> a -> Property -> LintWriter b isOrdInRange unwrapa l r p@(Property name _) = unwrapa p $ \int -> if l < int && int < r then pure () else complain $ "Property " <> prettyprint name <> " should be between " <> showText l <> " and " <> showText r<>"."