From 676fbcc0d6a8962ce9cb83136b2a0d0e9ff1e28e Mon Sep 17 00:00:00 2001 From: Eduardo Julian Date: Fri, 24 Aug 2018 00:19:02 -0400 Subject: Some micro-optimizations. --- luxc/src/lux/analyser/proc/common.clj | 13 +- luxc/src/lux/compiler/jvm/proc/common.clj | 25 +-- stdlib/source/lux/compiler/default/syntax.lux | 245 +++++++++++++------------- 3 files changed, 145 insertions(+), 138 deletions(-) diff --git a/luxc/src/lux/analyser/proc/common.clj b/luxc/src/lux/analyser/proc/common.clj index 7ce4974f7..fbdf05546 100644 --- a/luxc/src/lux/analyser/proc/common.clj +++ b/luxc/src/lux/analyser/proc/common.clj @@ -239,12 +239,13 @@ =input (&&/analyse-1 analyse &type/Nat ?input) _ (assert! (even? (&/|length ?pairs)) "The number of matches must be even!") =pairs (&/map% (fn [?pair] - (|let [[?pattern ?match] ?pair] - (|case ?pattern - [_ (&/$Text ^String ?pattern-char)] - (|do [=match (&&/analyse-1 analyse exo-type ?match)] - (return (&/T [(int (.charAt ?pattern-char 0)) - =match])))))) + (|let [[[_ (&/$Tuple ?patterns)] ?match] ?pair] + (|do [=match (&&/analyse-1 analyse exo-type ?match)] + (return (&/T [(&/|map (fn [?pattern] + (|let [[_ (&/$Text ^String ?pattern-char)] ?pattern] + (int (.charAt ?pattern-char 0)))) + ?patterns) + =match]))))) (&/|as-pairs ?pairs)) =else (&&/analyse-1 analyse exo-type ?else)] (return (&/|list (&&/|meta exo-type _cursor diff --git a/luxc/src/lux/compiler/jvm/proc/common.clj b/luxc/src/lux/compiler/jvm/proc/common.clj index dafcb64ef..5cff63d86 100644 --- a/luxc/src/lux/compiler/jvm/proc/common.clj +++ b/luxc/src/lux/compiler/jvm/proc/common.clj @@ -374,22 +374,25 @@ (defn ^:private compile-syntax-char-case! [compile ?values ?patterns] (|do [:let [(&/$Cons ?input (&/$Cons [_ (&a/$tuple ?matches)] (&/$Cons ?else (&/$Nil)))) ?values] ^MethodVisitor *writer* &/get-writer - :let [?patterns+?matches* (->> (&/zip2 ?patterns ?matches) - &/->seq - (sort-by &/|first <) - &/->list) - ?patterns* (&/|map &/|first ?patterns+?matches*) - ?matches* (&/|map &/|second ?patterns+?matches*) + :let [pattern-labels (&/|map (fn [_] (new Label)) ?patterns) + matched-patterns (->> (&/zip2 ?patterns pattern-labels) + (&/flat-map (fn [?chars+?label] + (|let [[?chars ?label] ?chars+?label] + (&/|map (fn [?char] + (&/T [?char ?label])) + ?chars)))) + &/->seq + (sort-by &/|first <) + &/->list) end-label (new Label) - else-label (new Label) - pattern-labels (&/|map (fn [_] (new Label)) ?patterns*)] + else-label (new Label)] _ (compile ?input) :let [_ (doto *writer* &&/unwrap-long (.visitInsn Opcodes/L2I) (.visitLookupSwitchInsn else-label - (int-array (&/->seq ?patterns*)) - (into-array (&/->seq pattern-labels))))] + (int-array (&/->seq (&/|map &/|first matched-patterns))) + (into-array (&/->seq (&/|map &/|second matched-patterns)))))] _ (&/map% (fn [?label+?match] (|let [[?label ?match] ?label+?match] (|do [:let [_ (doto *writer* @@ -398,7 +401,7 @@ :let [_ (doto *writer* (.visitJumpInsn Opcodes/GOTO end-label))]] (return nil)))) - (&/zip2 pattern-labels ?matches*)) + (&/zip2 pattern-labels ?matches)) :let [_ (doto *writer* (.visitLabel else-label))] _ (compile ?else) diff --git a/stdlib/source/lux/compiler/default/syntax.lux b/stdlib/source/lux/compiler/default/syntax.lux index d281cc168..2d6643da3 100644 --- a/stdlib/source/lux/compiler/default/syntax.lux +++ b/stdlib/source/lux/compiler/default/syntax.lux @@ -40,6 +40,10 @@ ["." list] ["." dictionary (#+ Dictionary)]]]]) +## TODO: Implement "lux syntax char case!" as a custom extension. +## That way, it should be possible to obtain the char without wrapping +## it into a java.lang.Long, thereby improving performance. + (type: #export Syntax (-> Cursor (Lexer [Cursor Code]))) @@ -149,8 +153,13 @@ (template: (!clip from to text) ("lux text clip" text from to)) -(template: (!i/< reference subject) - ("lux int <" subject reference)) +(do-template [ ] + [(template: ( reference subject) + ( subject reference))] + + [!n/= "lux i64 ="] + [!i/< "lux int <"] + ) (do-template [ ] [(template: ( param subject) @@ -183,16 +192,13 @@ (#error.Error error) (let [[where offset _] source] - (<| (!with-char+ source-code//size source-code offset char (#error.Error error)) - (`` (case char - (^ (char (~~ (static )))) - (#error.Success [[(update@ #.column inc where) - (!inc offset) - source-code] - [where ( (list.reverse stack))]]) - - _ - (ex.throw unrecognized-input where)))))))))] + (<| (!with-char+ source-code//size source-code offset closing-char (#error.Error error)) + (if (`` (!n/= (char (~~ (static ))) closing-char)) + (#error.Success [[(update@ #.column inc where) + (!inc offset) + source-code] + [where ( (list.reverse stack))]]) + (ex.throw unrecognized-input where))))))))] ## Form and tuple syntax is mostly the same, differing only in the ## delimiters involved. @@ -215,16 +221,13 @@ (#error.Error error) (let [[where offset _] source] - (<| (!with-char+ source-code//size source-code offset char (#error.Error error)) - (`` (case char - (^ (char (~~ (static ..close-record)))) - (#error.Success [[(update@ #.column inc where) - (!inc offset) - source-code] - [where (#.Record (list.reverse stack))]]) - - _ - (ex.throw unrecognized-input where)))))) + (<| (!with-char+ source-code//size source-code offset closing-char (#error.Error error)) + (if (`` (!n/= (char (~~ (static ..close-record))) closing-char)) + (#error.Success [[(update@ #.column inc where) + (!inc offset) + source-code] + [where (#.Record (list.reverse stack))]]) + (ex.throw unrecognized-input where))))) (#error.Error error) (#error.Error error))))) @@ -340,11 +343,9 @@ (let [source-code//size ("lux text size" source-code)] (loop [end offset] (<| (!with-char+ source-code//size source-code end char ) - (cond (!name-char? char) - (recur (!inc end)) - - ## else - )))))) + (if (!name-char? char) + (recur (!inc end)) + )))))) (template: (!new-line where) (let [[where::file where::line where::column] where] @@ -371,13 +372,10 @@ (`` (def: (parse-short-name current-module [where offset/0 source-code]) (-> Text Source (Error [Source Name])) (<| (!with-char source-code offset/0 char/0 ) - (case char/0 - (^ (char (~~ (static ..name-separator)))) + (if (!n/= (char (~~ (static ..name-separator))) char/0) (let [offset/1 (!inc offset/0)] (<| (!with-char source-code offset/1 char/1 ) (!parse-half-name offset/1 offset/2 char/1 current-module))) - - _ (!parse-half-name offset/0 offset/1 char/0 ..prelude))))) (template: (!parse-short-name @current-module @source @where @tag) @@ -395,8 +393,7 @@ (#error.Success [source' simple]) (let [[where' offset' source-code'] source'] (<| (!with-char source-code' offset' char/separator ) - (case char/separator - (^ (char (~~ (static ..name-separator)))) + (if (!n/= (char (~~ (static ..name-separator))) char/separator) (let [offset'' (!inc offset')] (case (..parse-name-part offset'' [where' offset'' source-code']) (#error.Success [source'' complex]) @@ -404,8 +401,6 @@ (#error.Error error) (#error.Error error))) - - _ ))) (#error.Error error) @@ -418,6 +413,11 @@ (#error.Error error) (#error.Error error))) + + (`` (template: (<>) + [(~~ (static ..close-form)) + (~~ (static ..close-tuple)) + (~~ (static ..close-record))])) (with-expansions [ (as-is (parse current-module aliases source-code//size)) (as-is (recur [(update@ #.column inc where) @@ -430,90 +430,93 @@ (exec [] (function (recur [where offset/0 source-code]) (<| (!with-char+ source-code//size source-code offset/0 char/0 ) - (`` ("lux syntax char case!" char/0 - [## White-space - (~~ (static ..space)) + ## The space was singled-out for special treatment + ## because of how common it is. + (`` (if (!n/= (char (~~ (static ..space))) char/0) - - (~~ (static text.carriage-return)) - - - (~~ (static text.new-line)) - (recur [(!new-line where) (!inc offset/0) source-code]) - - ## Form - (~~ (static ..open-form)) - (parse-form ) - - ## Tuple - (~~ (static ..open-tuple)) - (parse-tuple ) - - ## Record - (~~ (static ..open-record)) - (parse-record ) - - ## Text - (~~ (static ..text-delimiter)) - (let [offset/1 (!inc offset/0)] - (!read-text where offset/1 source-code)) - - ## Special code - (~~ (static ..sigil)) - (let [offset/1 (!inc offset/0)] - (<| (!with-char+ source-code//size source-code offset/1 char/1 ) - ("lux syntax char case!" char/1 - [(~~ (do-template [ ] - [ - (#error.Success [[(update@ #.column (|>> !inc/2) where) - (!inc offset/1) - source-code] - [where (#.Bit )]])] - - ["0" #0] - ["1" #1])) - - ## Single-line comment - (~~ (static ..sigil)) - (case ("lux text index" source-code (static text.new-line) offset/1) - (#.Some end) - (recur [(!new-line where) (!inc end) source-code]) - - _ - ) - - (~~ (static ..name-separator)) - (!parse-short-name current-module where #.Identifier)] - - ## else - (cond (!name-char?|head char/1) ## Tag - (!parse-full-name offset/1 where #.Tag) - - ## else - )))) - - (~~ (static ..name-separator)) - (let [offset/1 (!inc offset/0)] - (<| (!with-char+ source-code//size source-code offset/1 char/1 ) - (if (!digit? char/1) - (let [offset/2 (!inc offset/1)] - (!parse-rev source-code//size offset/0 where offset/2 source-code)) - (!parse-short-name current-module where #.Identifier)))) - - (~~ (static ..positive-sign)) - (!parse-signed source-code//size offset/0 where source-code ) - - (~~ (static ..negative-sign)) - (!parse-signed source-code//size offset/0 where source-code )] - - ## else - (cond (!digit? char/0) ## Natural number - (let [offset/1 (!inc offset/0)] - (!parse-nat source-code//size offset/0 where offset/1 source-code)) - - ## Identifier - (!strict-name-char? char/0) - (!parse-full-name offset/0 where #.Identifier) - - ## else - ))))))))) + ("lux syntax char case!" char/0 + [## New line + [(~~ (static text.carriage-return))] + + + [(~~ (static text.new-line))] + (recur [(!new-line where) (!inc offset/0) source-code]) + + ## Form + [(~~ (static ..open-form))] + (parse-form ) + + ## Tuple + [(~~ (static ..open-tuple))] + (parse-tuple ) + + ## Record + [(~~ (static ..open-record))] + (parse-record ) + + ## Text + [(~~ (static ..text-delimiter))] + (let [offset/1 (!inc offset/0)] + (!read-text where offset/1 source-code)) + + ## Special code + [(~~ (static ..sigil))] + (let [offset/1 (!inc offset/0)] + (<| (!with-char+ source-code//size source-code offset/1 char/1 ) + ("lux syntax char case!" char/1 + [(~~ (do-template [ ] + [[] + (#error.Success [[(update@ #.column (|>> !inc/2) where) + (!inc offset/1) + source-code] + [where (#.Bit )]])] + + ["0" #0] + ["1" #1])) + + ## Single-line comment + [(~~ (static ..sigil))] + (case ("lux text index" source-code (static text.new-line) offset/1) + (#.Some end) + (recur [(!new-line where) (!inc end) source-code]) + + _ + ) + + [(~~ (static ..name-separator))] + (!parse-short-name current-module where #.Identifier)] + + ## else + (cond (!name-char?|head char/1) ## Tag + (!parse-full-name offset/1 where #.Tag) + + ## else + )))) + + [(~~ (static ..name-separator))] + (let [offset/1 (!inc offset/0)] + (<| (!with-char+ source-code//size source-code offset/1 char/1 ) + (if (!digit? char/1) + (let [offset/2 (!inc offset/1)] + (!parse-rev source-code//size offset/0 where offset/2 source-code)) + (!parse-short-name current-module where #.Identifier)))) + + [(~~ (static ..positive-sign)) + (~~ (static ..negative-sign))] + (!parse-signed source-code//size offset/0 where source-code ) + + ## Invalid characters at this point... + (~~ (<>)) + ] + + ## else + (if (!digit? char/0) + ## Natural number + (let [offset/1 (!inc offset/0)] + (!parse-nat source-code//size offset/0 where offset/1 source-code)) + ## Identifier + (!parse-full-name offset/0 where #.Identifier)) + ))) + ))) + )) + ) -- cgit v1.2.3