From 332413bcaa7e1c810f236239474d997eb5d1aa43 Mon Sep 17 00:00:00 2001 From: Wu Cheng-Han Date: Sat, 26 Sep 2015 10:25:00 +0800 Subject: Fixed if using splice in loop should always decrement index or might out of array range --- public/js/history.js | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) (limited to 'public') diff --git a/public/js/history.js b/public/js/history.js index 10ab932f..82c145da 100644 --- a/public/js/history.js +++ b/public/js/history.js @@ -123,8 +123,10 @@ function addHistory(id, text, time, tags, notehistory) { function removeHistory(id, notehistory) { for (var i = 0; i < notehistory.length; i++) { - if (notehistory[i].id == id) + if (notehistory[i].id == id) { notehistory.splice(i, 1); + i--; + } } return notehistory; } -- cgit v1.2.3