From 02e99277146d8bd912f2f19af1d3e94a6181d90d Mon Sep 17 00:00:00 2001
From: alecdwm
Date: Tue, 13 Dec 2016 22:31:35 +0100
Subject: Initial support for LDAP server authentication
Limitations as of this commit:
- tlsOptions can only be specified in config.json, not as env vars
- authentication failures are not yet gracefully handled by the UI
- instead the error message is shown on a blank page (/auth/ldap)
- no email address is associated with the LDAP user's account
- no picture/profile URL is associated with the LDAP user's account
- we might have to generate our own access + refresh tokens,
because we aren't using oauth. The currently generated
tokens are just a placeholder.
- 'LDAP Sign in' needs to be translated to each locale
---
public/views/signin-modal.ejs | 10 ++++++++--
1 file changed, 8 insertions(+), 2 deletions(-)
(limited to 'public/views/signin-modal.ejs')
diff --git a/public/views/signin-modal.ejs b/public/views/signin-modal.ejs
index acbad256..ba6c57ff 100644
--- a/public/views/signin-modal.ejs
+++ b/public/views/signin-modal.ejs
@@ -38,7 +38,13 @@
<%= __('Sign in via %s', 'Google') %>
<% } %>
- <% if((facebook || twitter || github || gitlab || dropbox || google) && email) { %>
+ <% if(ldap) { %>
+
+ <%= __('Sign in via %s', 'LDAP') %>
+
+ <% } %>
+
+ <% if((facebook || twitter || github || gitlab || dropbox || google || ldap) && email) { %>
<% }%>
<% if(email) { %>
@@ -67,4 +73,4 @@
-
\ No newline at end of file
+
--
cgit v1.2.3
From 72a0e90f7d09d8a4e06a2629dcb9404eb37c64a0 Mon Sep 17 00:00:00 2001
From: alecdwm
Date: Wed, 14 Dec 2016 12:42:42 +0100
Subject: LDAP signin form moved to main signin-modal
- previously was a separate modal
- now is located on main modal, like email auth
---
public/views/signin-modal.ejs | 27 +++++++++++++++++++++++----
1 file changed, 23 insertions(+), 4 deletions(-)
(limited to 'public/views/signin-modal.ejs')
diff --git a/public/views/signin-modal.ejs b/public/views/signin-modal.ejs
index ba6c57ff..e71b09c6 100644
--- a/public/views/signin-modal.ejs
+++ b/public/views/signin-modal.ejs
@@ -38,12 +38,31 @@
<%= __('Sign in via %s', 'Google') %>
<% } %>
+ <% if((facebook || twitter || github || gitlab || dropbox || google) && ldap) { %>
+
+ <% }%>
<% if(ldap) { %>
-
- <%= __('Sign in via %s', 'LDAP') %>
-
+ Via LDAP
+
<% } %>
-
<% if((facebook || twitter || github || gitlab || dropbox || google || ldap) && email) { %>
<% }%>
--
cgit v1.2.3
From ff545b268871be7b6552638427a59a9a6eac5dd1 Mon Sep 17 00:00:00 2001
From: neopostmodern
Date: Mon, 9 Jan 2017 12:49:23 +0100
Subject: Allow displaying LDAP provider name on sign-in modal
---
public/views/signin-modal.ejs | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
(limited to 'public/views/signin-modal.ejs')
diff --git a/public/views/signin-modal.ejs b/public/views/signin-modal.ejs
index 7c52e0f3..e9c54b33 100644
--- a/public/views/signin-modal.ejs
+++ b/public/views/signin-modal.ejs
@@ -42,7 +42,7 @@
<% }%>
<% if(ldap) { %>
- Via LDAP
+ Via <% if (ldap.providerName) { %> <%- ldap.providerName %> (LDAP) <% } else { %> LDAP <% } %>