From 1756e76dc31495d03c8792fa672ae6bb94d24ea8 Mon Sep 17 00:00:00 2001 From: Sheogorath Date: Sun, 18 Mar 2018 02:14:50 +0100 Subject: Refactoring imageRouter to modularity This should make the imageRouter more modular and easier to extent. Also a lot of code duplication was removed which should simplify maintenance in future. In the new setup we only need to provide a new module file which exports a function called `uploadImage` and takes a filePath and a callback as argument. The callback itself takes an error and an url as parameter. This eliminates the need of a try-catch-block around the statement and re-enabled the optimization in NodeJS. Signed-off-by: Sheogorath --- lib/web/imageRouter/filesystem.js | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) create mode 100644 lib/web/imageRouter/filesystem.js (limited to 'lib/web/imageRouter/filesystem.js') diff --git a/lib/web/imageRouter/filesystem.js b/lib/web/imageRouter/filesystem.js new file mode 100644 index 00000000..25ec3846 --- /dev/null +++ b/lib/web/imageRouter/filesystem.js @@ -0,0 +1,18 @@ +'use strict' +const url = require('url') + +const config = require('../../config') + +exports.uploadImage = function (imagePath, callback) { + if (!imagePath || typeof imagePath !== 'string') { + callback(new Error('Image path is missing or wrong'), null) + return + } + + if (!callback || typeof callback !== 'function') { + callback(new Error('Callback has to be a function'), null) + return + } + + callback(null, url.resolve(config.serverurl + '/', imagePath.match(/^public\/(.+$)/)[1])) +} -- cgit v1.2.3