From 1756e76dc31495d03c8792fa672ae6bb94d24ea8 Mon Sep 17 00:00:00 2001 From: Sheogorath Date: Sun, 18 Mar 2018 02:14:50 +0100 Subject: Refactoring imageRouter to modularity This should make the imageRouter more modular and easier to extent. Also a lot of code duplication was removed which should simplify maintenance in future. In the new setup we only need to provide a new module file which exports a function called `uploadImage` and takes a filePath and a callback as argument. The callback itself takes an error and an url as parameter. This eliminates the need of a try-catch-block around the statement and re-enabled the optimization in NodeJS. Signed-off-by: Sheogorath --- lib/config/index.js | 7 +++++++ 1 file changed, 7 insertions(+) (limited to 'lib/config/index.js') diff --git a/lib/config/index.js b/lib/config/index.js index 0051e485..abcd2b3e 100644 --- a/lib/config/index.js +++ b/lib/config/index.js @@ -6,6 +6,7 @@ const path = require('path') const {merge} = require('lodash') const deepFreeze = require('deep-freeze') const {Environment, Permission} = require('./enum') +const logger = require('../logger') const appRootPath = path.join(__dirname, '../../') const env = process.env.NODE_ENV || Environment.development @@ -103,6 +104,12 @@ if (config.imageUploadType && !config.imageuploadtype) { config.imageuploadtype = config.imageUploadType } +// Validate upload upload providers +if (['filesystem', 's3', 'minio', 'imgur'].indexOf(config.imageuploadtype) === -1) { + logger.error('"imageuploadtype" is not correctly set. Please use "filesystem", "s3", "minio" or "imgur". Defaulting to "imgur"') + config.imageuploadtype = 'imgur' +} + // figure out mime types for image uploads switch (config.imageuploadtype) { case 'imgur': -- cgit v1.2.3