From 3b728aff86a086f71f013b77a715c33748d9f6a8 Mon Sep 17 00:00:00 2001 From: Nadrieril Date: Wed, 28 Oct 2020 21:45:42 +0000 Subject: Make type annotation optional to allow serializing SimpleValue --- serde_dhall/src/options/de.rs | 37 +++-------- serde_dhall/src/options/mod.rs | 34 ++++++++++ serde_dhall/src/options/ser.rs | 33 +++------- serde_dhall/src/serialize.rs | 16 ++++- serde_dhall/src/value.rs | 140 ++++++++++++++++++++++------------------- 5 files changed, 138 insertions(+), 122 deletions(-) (limited to 'serde_dhall/src') diff --git a/serde_dhall/src/options/de.rs b/serde_dhall/src/options/de.rs index 8ff794d..e4f3456 100644 --- a/serde_dhall/src/options/de.rs +++ b/serde_dhall/src/options/de.rs @@ -2,8 +2,9 @@ use std::path::{Path, PathBuf}; use dhall::Parsed; +use crate::options::{HasAnnot, ManualAnnot, NoAnnot, StaticAnnot, TypeAnnot}; use crate::SimpleType; -use crate::{Error, ErrorKind, FromDhall, Result, StaticType, Value}; +use crate::{Error, ErrorKind, FromDhall, Result, Value}; #[derive(Debug, Clone)] enum Source<'a> { @@ -12,32 +13,6 @@ enum Source<'a> { // Url(&'a str), } -#[derive(Debug, Clone, Copy)] -pub struct NoAnnot; -#[derive(Debug, Clone, Copy)] -pub struct ManualAnnot<'ty>(&'ty SimpleType); -#[derive(Debug, Clone, Copy)] -pub struct StaticAnnot; - -pub trait OptionalAnnot { - fn get_annot(a: &A) -> Option; -} -impl OptionalAnnot for T { - fn get_annot(_: &NoAnnot) -> Option { - None - } -} -impl<'ty, T> OptionalAnnot> for T { - fn get_annot(a: &ManualAnnot<'ty>) -> Option { - Some(a.0.clone()) - } -} -impl OptionalAnnot for T { - fn get_annot(_: &StaticAnnot) -> Option { - Some(T::static_type()) - } -} - /// Controls how a Dhall value is read. /// /// This builder exposes the ability to configure how a value is deserialized and what operations @@ -252,7 +227,8 @@ impl<'a, A> Deserializer<'a, A> { fn _parse(&self) -> dhall::error::Result where - T: OptionalAnnot, + A: TypeAnnot, + T: HasAnnot, { let parsed = match &self.source { Source::Str(s) => Parsed::parse_str(s)?, @@ -263,7 +239,7 @@ impl<'a, A> Deserializer<'a, A> { } else { parsed.skip_resolve()? }; - let typed = match &T::get_annot(&self.annot) { + let typed = match &T::get_annot(self.annot) { None => resolved.typecheck()?, Some(ty) => resolved.typecheck_with(ty.to_value().as_hir())?, }; @@ -287,7 +263,8 @@ impl<'a, A> Deserializer<'a, A> { /// [`StaticType`]: trait.StaticType.html pub fn parse(&self) -> Result where - T: FromDhall + OptionalAnnot, + A: TypeAnnot, + T: FromDhall + HasAnnot, { let val = self ._parse::() diff --git a/serde_dhall/src/options/mod.rs b/serde_dhall/src/options/mod.rs index 384f318..9241c45 100644 --- a/serde_dhall/src/options/mod.rs +++ b/serde_dhall/src/options/mod.rs @@ -1,2 +1,36 @@ +use crate::{SimpleType, StaticType}; + pub(crate) mod de; pub(crate) mod ser; + +#[derive(Debug, Clone, Copy)] +pub struct NoAnnot; +#[derive(Debug, Clone, Copy)] +pub struct ManualAnnot<'ty>(&'ty SimpleType); +#[derive(Debug, Clone, Copy)] +pub struct StaticAnnot; + +pub trait TypeAnnot: Copy {} +pub trait HasAnnot { + fn get_annot(a: A) -> Option; +} + +impl TypeAnnot for NoAnnot {} +impl TypeAnnot for ManualAnnot<'_> {} +impl TypeAnnot for StaticAnnot {} + +impl HasAnnot for T { + fn get_annot(_: NoAnnot) -> Option { + None + } +} +impl HasAnnot> for T { + fn get_annot(a: ManualAnnot<'_>) -> Option { + Some(a.0.clone()) + } +} +impl HasAnnot for T { + fn get_annot(_: StaticAnnot) -> Option { + Some(T::static_type()) + } +} diff --git a/serde_dhall/src/options/ser.rs b/serde_dhall/src/options/ser.rs index 026dd21..ea5d16a 100644 --- a/serde_dhall/src/options/ser.rs +++ b/serde_dhall/src/options/ser.rs @@ -1,25 +1,5 @@ -use crate::{Result, SimpleType, StaticType, ToDhall}; - -#[derive(Debug, Clone, Copy)] -pub struct NoAnnot; -#[derive(Debug, Clone, Copy)] -pub struct ManualAnnot<'ty>(&'ty SimpleType); -#[derive(Debug, Clone, Copy)] -pub struct StaticAnnot; - -pub trait RequiredAnnot { - fn get_annot(a: &A) -> SimpleType; -} -impl<'ty, T> RequiredAnnot> for T { - fn get_annot(a: &ManualAnnot<'ty>) -> SimpleType { - a.0.clone() - } -} -impl RequiredAnnot for T { - fn get_annot(_: &StaticAnnot) -> SimpleType { - T::static_type() - } -} +use crate::options::{HasAnnot, ManualAnnot, NoAnnot, StaticAnnot, TypeAnnot}; +use crate::{Result, SimpleType, ToDhall}; #[derive(Debug, Clone)] pub struct Serializer<'a, T, A> { @@ -46,12 +26,15 @@ impl<'a, T> Serializer<'a, T, NoAnnot> { } } -impl<'a, T, A> Serializer<'a, T, A> { +impl<'a, T, A> Serializer<'a, T, A> +where + A: TypeAnnot, +{ pub fn to_string(&self) -> Result where - T: ToDhall + RequiredAnnot, + T: ToDhall + HasAnnot, { - let val = self.data.to_dhall(&T::get_annot(&self.annot))?; + let val = self.data.to_dhall(T::get_annot(self.annot).as_ref())?; Ok(val.to_string()) } } diff --git a/serde_dhall/src/serialize.rs b/serde_dhall/src/serialize.rs index dd3e426..21b1931 100644 --- a/serde_dhall/src/serialize.rs +++ b/serde_dhall/src/serialize.rs @@ -11,7 +11,7 @@ pub trait Sealed {} pub trait ToDhall: Sealed { #[doc(hidden)] - fn to_dhall(&self, ty: &SimpleType) -> Result; + fn to_dhall(&self, ty: Option<&SimpleType>) -> Result; } impl Sealed for T where T: ser::Serialize {} @@ -20,7 +20,7 @@ impl ToDhall for T where T: ser::Serialize, { - fn to_dhall(&self, ty: &SimpleType) -> Result { + fn to_dhall(&self, ty: Option<&SimpleType>) -> Result { let sval: SimpleValue = self.serialize(Serializer)?; sval.into_value(ty) } @@ -310,3 +310,15 @@ impl ser::SerializeStruct for StructSerializer { Ok(Record(self.0)) } } + +impl serde::ser::Serialize for SimpleValue { + fn serialize( + &self, + serializer: S, + ) -> std::result::Result + where + S: serde::ser::Serializer, + { + todo!() + } +} diff --git a/serde_dhall/src/value.rs b/serde_dhall/src/value.rs index ca05658..50c12bd 100644 --- a/serde_dhall/src/value.rs +++ b/serde_dhall/src/value.rs @@ -293,87 +293,103 @@ impl SimpleValue { }) } - fn to_hir(&self, ty: &SimpleType) -> Result { + // Converts this to `Hir`, using the optional type annotation. Without the type, things like + // empty lists and unions will fail to convert. + fn to_hir(&self, ty: Option<&SimpleType>) -> Result { use SimpleType as T; use SimpleValue as V; let hir = |k| Hir::new(HirKind::Expr(k), Span::Artificial); - let type_error = |msg| Error(ErrorKind::Serialize(msg)); + let type_error = || { + Error(ErrorKind::Serialize(format!( + "expected a value of type {}, found {:?}", + ty.unwrap().to_hir().to_expr(Default::default()), + self + ))) + }; + let type_missing = || { + Error(ErrorKind::Serialize(format!( + "cannot serialize value without a type annotation: {:?}", + self + ))) + }; let kind = match (self, ty) { - (V::Num(num @ NumKind::Bool(_)), T::Bool) - | (V::Num(num @ NumKind::Natural(_)), T::Natural) - | (V::Num(num @ NumKind::Integer(_)), T::Integer) - | (V::Num(num @ NumKind::Double(_)), T::Double) => { - ExprKind::Num(num.clone()) + (V::Num(num @ NumKind::Bool(_)), Some(T::Bool)) + | (V::Num(num @ NumKind::Natural(_)), Some(T::Natural)) + | (V::Num(num @ NumKind::Integer(_)), Some(T::Integer)) + | (V::Num(num @ NumKind::Double(_)), Some(T::Double)) + | (V::Num(num), None) => ExprKind::Num(num.clone()), + (V::Text(v), Some(T::Text)) | (V::Text(v), None) => { + ExprKind::TextLit(v.clone().into()) } - (V::Text(v), T::Text) => ExprKind::TextLit(v.clone().into()), - (V::Optional(None), T::Optional(t)) => ExprKind::Op(OpKind::App( - hir(ExprKind::Builtin(Builtin::OptionalNone)), - t.to_hir(), - )), - (V::Optional(Some(v)), T::Optional(t)) => { - ExprKind::SomeLit(v.to_hir(t)?) + + (V::Optional(None), None) => return Err(type_missing()), + (V::Optional(None), Some(T::Optional(t))) => { + ExprKind::Op(OpKind::App( + hir(ExprKind::Builtin(Builtin::OptionalNone)), + t.to_hir(), + )) + } + (V::Optional(Some(v)), None) => ExprKind::SomeLit(v.to_hir(None)?), + (V::Optional(Some(v)), Some(T::Optional(t))) => { + ExprKind::SomeLit(v.to_hir(Some(t))?) } - (V::List(v), T::List(t)) if v.is_empty() => { + + (V::List(v), None) if v.is_empty() => return Err(type_missing()), + (V::List(v), Some(T::List(t))) if v.is_empty() => { ExprKind::EmptyListLit(hir(ExprKind::Op(OpKind::App( hir(ExprKind::Builtin(Builtin::List)), t.to_hir(), )))) } - (V::List(v), T::List(t)) => ExprKind::NEListLit( - v.iter().map(|v| v.to_hir(t)).collect::>()?, + (V::List(v), None) => ExprKind::NEListLit( + v.iter().map(|v| v.to_hir(None)).collect::>()?, + ), + (V::List(v), Some(T::List(t))) => ExprKind::NEListLit( + v.iter().map(|v| v.to_hir(Some(t))).collect::>()?, + ), + + (V::Record(v), None) => ExprKind::RecordLit( + v.iter() + .map(|(k, v)| Ok((k.clone().into(), v.to_hir(None)?))) + .collect::>()?, ), - (V::Record(v), T::Record(t)) => ExprKind::RecordLit( + (V::Record(v), Some(T::Record(t))) => ExprKind::RecordLit( v.iter() .map(|(k, v)| match t.get(k) { - Some(t) => Ok((k.clone().into(), v.to_hir(t)?)), - None => Err(type_error(format!( - "expected a value of type {}, found {:?}", - ty.to_hir().to_expr(Default::default()), - self - ))), + Some(t) => Ok((k.clone().into(), v.to_hir(Some(t))?)), + None => Err(type_error()), }) .collect::>()?, ), - (V::Union(variant, Some(v)), T::Union(t)) => match t.get(variant) { - Some(Some(variant_t)) => ExprKind::Op(OpKind::App( - hir(ExprKind::Op(OpKind::Field( - ty.to_hir(), - variant.clone().into(), - ))), - v.to_hir(variant_t)?, - )), - _ => { - return Err(type_error(format!( - "expected a value of type {}, found {:?}", - ty.to_hir().to_expr(Default::default()), - self - ))) + + (V::Union(..), None) => return Err(type_missing()), + (V::Union(variant, Some(v)), Some(T::Union(t))) => { + match t.get(variant) { + Some(Some(variant_t)) => ExprKind::Op(OpKind::App( + hir(ExprKind::Op(OpKind::Field( + ty.unwrap().to_hir(), + variant.clone().into(), + ))), + v.to_hir(Some(variant_t))?, + )), + _ => return Err(type_error()), } - }, - (V::Union(variant, None), T::Union(t)) => match t.get(variant) { - Some(None) => ExprKind::Op(OpKind::Field( - ty.to_hir(), - variant.clone().into(), - )), - _ => { - return Err(type_error(format!( - "expected a value of type {}, found {:?}", - ty.to_hir().to_expr(Default::default()), - self - ))) + } + (V::Union(variant, None), Some(T::Union(t))) => { + match t.get(variant) { + Some(None) => ExprKind::Op(OpKind::Field( + ty.unwrap().to_hir(), + variant.clone().into(), + )), + _ => return Err(type_error()), } - }, - _ => { - return Err(type_error(format!( - "expected a value of type {}, found {:?}", - ty.to_hir().to_expr(Default::default()), - self - ))) } + + (_, Some(_)) => return Err(type_error()), }; Ok(hir(kind)) } - pub(crate) fn into_value(self, ty: &SimpleType) -> Result { + pub(crate) fn into_value(self, ty: Option<&SimpleType>) -> Result { Ok(Value { hir: self.to_hir(ty)?, as_simple_val: Some(self), @@ -467,7 +483,6 @@ impl SimpleType { impl crate::deserialize::Sealed for Value {} impl crate::deserialize::Sealed for SimpleType {} impl crate::serialize::Sealed for Value {} -impl crate::serialize::Sealed for SimpleValue {} impl FromDhall for Value { fn from_dhall(v: &Value) -> Result { @@ -485,15 +500,10 @@ impl FromDhall for SimpleType { } } impl ToDhall for Value { - fn to_dhall(&self, _ty: &SimpleType) -> Result { + fn to_dhall(&self, _ty: Option<&SimpleType>) -> Result { Ok(self.clone()) } } -impl ToDhall for SimpleValue { - fn to_dhall(&self, ty: &SimpleType) -> Result { - self.clone().into_value(ty) - } -} impl Eq for Value {} impl PartialEq for Value { -- cgit v1.2.3