From 9b67852327aff5263a3c119c068170b2edef69f8 Mon Sep 17 00:00:00 2001
From: Nadrieril
Date: Sun, 1 Nov 2020 18:00:07 +0000
Subject: Don't pollute the dhall cache directory

---
 Cargo.lock          |  7 +++++
 dhall/Cargo.toml    |  4 +--
 dhall/tests/spec.rs | 80 +++++++++++++++++++++++++++++++----------------------
 3 files changed, 55 insertions(+), 36 deletions(-)

diff --git a/Cargo.lock b/Cargo.lock
index 63522c2..503f711 100644
--- a/Cargo.lock
+++ b/Cargo.lock
@@ -300,6 +300,7 @@ dependencies = [
  "annotate-snippets",
  "anyhow",
  "colored-diff",
+ "fs_extra",
  "hex",
  "itertools 0.9.0",
  "lazy_static",
@@ -408,6 +409,12 @@ version = "0.1.1"
 source = "registry+https://github.com/rust-lang/crates.io-index"
 checksum = "00b0228411908ca8685dba7fc2cdd70ec9990a6e753e89b6ac91a84c40fbaf4b"
 
+[[package]]
+name = "fs_extra"
+version = "1.2.0"
+source = "registry+https://github.com/rust-lang/crates.io-index"
+checksum = "2022715d62ab30faffd124d40b76f4134a550a87792276512b18d63272333394"
+
 [[package]]
 name = "fuchsia-zircon"
 version = "0.3.3"
diff --git a/dhall/Cargo.toml b/dhall/Cargo.toml
index 7923009..207539a 100644
--- a/dhall/Cargo.toml
+++ b/dhall/Cargo.toml
@@ -41,15 +41,13 @@ reqwest = { version = "0.10", features = ["blocking"], optional = true }
 [dev-dependencies]
 anyhow = "1.0.28"
 colored-diff = "0.2.2"
+fs_extra = "1.2.0"
 libtest-mimic = "0.3.0"
 rand = "0.7"
 version-sync = "0.9"
 walkdir = "2"
 
 [build-dependencies]
-walkdir = "2"
 abnf_to_pest = { version = "^0.5.0", path = "../abnf_to_pest" }
 pest_generator = "2.1.3"
 quote = "1.0"
-
-
diff --git a/dhall/tests/spec.rs b/dhall/tests/spec.rs
index ae53f4a..36cbd81 100644
--- a/dhall/tests/spec.rs
+++ b/dhall/tests/spec.rs
@@ -1,4 +1,6 @@
 use anyhow::Result;
+use rand::distributions::Alphanumeric;
+use rand::Rng;
 use std::env;
 use std::ffi::OsString;
 use std::fmt::{Debug, Display};
@@ -593,26 +595,6 @@ fn unwrap_err<T: Debug, E>(x: Result<T, E>) -> Result<E, TestError> {
 
 fn run_test(test: &SpecTest) -> Result<()> {
     use self::SpecTestKind::*;
-    // Setup current directory to the root of the repository. Important for `as Location` tests.
-    let root_dir = PathBuf::from(env!("CARGO_MANIFEST_DIR"))
-        .parent()
-        .unwrap()
-        .to_path_buf();
-    env::set_current_dir(root_dir.as_path())?;
-    // Set environment variable for import tests.
-    env::set_var("DHALL_TEST_VAR", "6 * 7");
-
-    // Configure cache for import tests
-    env::set_var(
-        "XDG_CACHE_HOME",
-        root_dir
-            .join("dhall-lang")
-            .join("tests")
-            .join("import")
-            .join("cache")
-            .as_path(),
-    );
-
     let SpecTest {
         input: expr,
         output: expected,
@@ -690,7 +672,6 @@ fn run_test(test: &SpecTest) -> Result<()> {
             expected.compare(expr)?;
         }
     }
-
     Ok(())
 }
 
@@ -700,17 +681,50 @@ fn main() {
         .flat_map(discover_tests_for_feature)
         .collect();
 
-    libtest_mimic::run_tests(&Arguments::from_args(), tests, |test| {
-        let result = std::panic::catch_unwind(move || {
-            run_test_stringy_error(&test.data)
+    // Setup current directory to the root of the repository. Important for `as Location` tests.
+    let root_dir = PathBuf::from(env!("CARGO_MANIFEST_DIR"))
+        .parent()
+        .unwrap()
+        .to_path_buf();
+    env::set_current_dir(root_dir.as_path()).unwrap();
+
+    // Set environment variable for import tests.
+    env::set_var("DHALL_TEST_VAR", "6 * 7");
+
+    // Configure cache for import tests
+    let dhall_cache_dir = root_dir
+        .join("dhall-lang")
+        .join("tests")
+        .join("import")
+        .join("cache")
+        .join("dhall");
+    let random_id = rand::thread_rng()
+        .sample_iter(Alphanumeric)
+        .take(36)
+        .collect::<String>();
+    let cache_dir = format!("dhall-tests-{}", random_id);
+    let cache_dir = env::temp_dir().join(cache_dir);
+
+    std::fs::create_dir_all(&cache_dir).unwrap();
+    fs_extra::dir::copy(&dhall_cache_dir, &cache_dir, &Default::default())
+        .unwrap();
+    env::set_var("XDG_CACHE_HOME", &cache_dir);
+
+    let res =
+        libtest_mimic::run_tests(&Arguments::from_args(), tests, |test| {
+            let result = std::panic::catch_unwind(move || {
+                run_test_stringy_error(&test.data)
+            });
+            match result {
+                Ok(Ok(_)) => Outcome::Passed,
+                Ok(Err(e)) => Outcome::Failed { msg: Some(e) },
+                Err(_) => Outcome::Failed {
+                    msg: Some("thread panicked".to_string()),
+                },
+            }
         });
-        match result {
-            Ok(Ok(_)) => Outcome::Passed,
-            Ok(Err(e)) => Outcome::Failed { msg: Some(e) },
-            Err(_) => Outcome::Failed {
-                msg: Some("thread panicked".to_string()),
-            },
-        }
-    })
-    .exit();
+
+    std::fs::remove_dir_all(&cache_dir).unwrap();
+
+    res.exit();
 }
-- 
cgit v1.2.3