From 3cfc12a2ca5e7d5f6a9c64ddfda025d7599ec8d8 Mon Sep 17 00:00:00 2001
From: notgne2
Date: Sat, 7 Nov 2020 00:13:31 -0700
Subject: Unmute some more outputs, document the remaining mutes

---
 src/activate.rs   | 7 -------
 src/main.rs       | 1 +
 src/utils/push.rs | 3 +--
 3 files changed, 2 insertions(+), 9 deletions(-)

(limited to 'src')

diff --git a/src/activate.rs b/src/activate.rs
index ae9e814..71dca72 100644
--- a/src/activate.rs
+++ b/src/activate.rs
@@ -87,8 +87,6 @@ pub async fn deactivate(profile_path: &str) -> Result<(), DeactivateError> {
         .arg("-p")
         .arg(&profile_path)
         .arg("--rollback")
-        .stdout(Stdio::null())
-        .stderr(Stdio::null())
         .status()
         .await
         .map_err(DeactivateError::RollbackError)?;
@@ -133,8 +131,6 @@ pub async fn deactivate(profile_path: &str) -> Result<(), DeactivateError> {
         .arg(&profile_path)
         .arg("--delete-generations")
         .arg(last_generation_id)
-        .stdout(Stdio::null())
-        .stderr(Stdio::null())
         .status()
         .await
         .map_err(DeactivateError::DeleteGenError)?;
@@ -298,7 +294,6 @@ pub async fn activate(
         .arg(&profile_path)
         .arg("--set")
         .arg(&closure)
-        .stdout(Stdio::null())
         .status()
         .await
         .map_err(ActivateError::SetProfileError)?;
@@ -316,8 +311,6 @@ pub async fn activate(
             .arg("-c")
             .arg(&bootstrap_cmd)
             .env("PROFILE", &profile_path)
-            .stdout(Stdio::null())
-            .stderr(Stdio::null())
             .status()
             .await;
 
diff --git a/src/main.rs b/src/main.rs
index 91adae3..cb297ad 100644
--- a/src/main.rs
+++ b/src/main.rs
@@ -226,6 +226,7 @@ async fn test_flake_support() -> Result<bool, std::io::Error> {
         .arg("eval")
         .arg("--expr")
         .arg("builtins.getFlake")
+        // This will error on some machines "intentionally", and we don't really need that printing
         .stdout(Stdio::null())
         .stderr(Stdio::null())
         .status()
diff --git a/src/utils/push.rs b/src/utils/push.rs
index 16bf8e7..d52fbbe 100644
--- a/src/utils/push.rs
+++ b/src/utils/push.rs
@@ -75,6 +75,7 @@ pub async fn push_profile(
     };
 
     let build_exit_status = build_command
+        // Logging should be in stderr, this just stops the store path from printing for no reason
         .stdout(Stdio::null())
         .status()
         .await
@@ -100,8 +101,6 @@ pub async fn push_profile(
             .arg(&super::deploy_path_to_activate_path_str(
                 &deploy_defs.current_exe,
             )?)
-            .stdout(Stdio::null())
-            .stderr(Stdio::null())
             .status()
             .await
             .map_err(PushProfileError::SignError)?;
-- 
cgit v1.2.3